Do not find duplicates on empty string

global-121 · Feb 20, 2025 · 5402d3e · 5402d3e
1 parent 7e812d2
commit 5402d3e
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/services/121-service/src/registration/repositories/registration-scoped.repository.ts b/services/121-service/src/registration/repositories/registration-scoped.repository.ts
@@ -229,6 +229,7 @@ export class RegistrationScopedRepository extends RegistrationScopedBaseReposito
       )
       .andWhere('attribute."duplicateCheck" = true')
       .andWhere('duplicate."programId" = :programId', { programId })
+      .andWhere(`"attributeData1"."value" != ''`)
       .orderBy('"attributeData1"."programRegistrationAttributeId"', 'ASC')
       .limit(maxDuplicates)
       .getRawMany();

diff --git a/services/121-service/test/registrations/duplicates/get-duplicates.test.ts b/services/121-service/test/registrations/duplicates/get-duplicates.test.ts
@@ -296,4 +296,24 @@ describe('Get duplicate status of registrations', () => {
       isInScope: true,
     });
   });
+
+  it(`should not find duplicates on empty values`, async () => {
+    const registration1 = { ...registrationPV5 };
+    const registration2 = { ...registrationPV6 };
+
+    registration1.phoneNumber = '';
+    registration2.phoneNumber = '';
+    await importRegistrations(
+      programId,
+      [registration1, registration2],
+      accessToken,
+    );
+    const result = await getDuplicates({
+      programId,
+      accessToken,
+      referenceId: registration1.referenceId,
+    });
+    const duplicates = result.body;
+    expect(duplicates.length).toBe(0);
+  });
 });