Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI checks using Github Actions #52

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Add CI checks using Github Actions #52

merged 2 commits into from
Apr 2, 2020

Conversation

chiragpat
Copy link
Collaborator

@chiragpat chiragpat commented Apr 2, 2020

  • Setting yarn version in volta config
  • Executing yarn test on push to master and pull requests
  • Modified commonjs tests to only include the commonjs plugin to reduce test execution time

@chiragpat chiragpat force-pushed the github-actions branch 3 times, most recently from 7abb64b to 584ee66 Compare April 2, 2020 17:20
@rwjblue
Copy link
Member

rwjblue commented Apr 2, 2020

👋 - I made similar changes over in glimmerjs/glimmer.js#264. I think you should probably add volta config to each package which is required until volta-cli/volta#378 is resolved (otherwise yarn workspaces test may resolve different node/yarn versions since they change CWD).

@chiragpat
Copy link
Collaborator Author

Thanks! for the heads up will update all the child package.json files.

@chiragpat chiragpat merged commit c83abd8 into master Apr 2, 2020
@rwjblue rwjblue mentioned this pull request Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants