Add rich integration for Github Enterprise

[jasonwilliams]

I've tried setting up a remote to an Enterprise Server using "gitlens.remotes": [{ "domain": "git.corporate-url.com", "type": "GitHub", "protocol": "https" }] but this triggers an authentification workflow that takes me to github.com. Even though I authenticate correctly there it's the wrong Github so it this doesn't work. (also is there a way to reset this?)

Can i have an option to pass in a token instead from my Enterprise Github account?

I can't seem to avoid the "The extension 'GitLens — Git supercharged' wants to sign in using GitHub."

Github Pull Request extension allows the user to do this:
https://github.com/microsoft/vscode-pull-request-github/wiki#personal-access-token-authentication

Now i just get:

[2020-11-25 13:00:15:177] GitHubApi.getPullRequestForCommit
Error: Bad credentials

in my logs when i run commands that need the server.

[jasonwilliams]

I believe so -- during the VS Code auth flow (when it opens the browser window), I believe there is an entry in the statusbar that you can click that will prompt for a PAT. But I don't believe you can create a PAT with any less scopes than I am currently asking for -- because repo info, prs, issues etc are all under the repo scope.

Weird i tried creating a token with repo scope and it failed for me:

Below log from "Github Authentification"

[Info  - 17:11:35.813] Logging in...
[Info  - 17:12:44.990] Treating input as token
[Info  - 17:12:44.990] Getting user info...
[Error  - 17:12:45.321] Getting account info failed: Unauthorized

I think it could be trying to log in to the wrong github

im going to assume its related to this microsoft/vscode-pull-request-github#1755

[eamodio]

Unfortunately this is an issue with the VS Code auth provider: microsoft/vscode#112043

Until that issue is resolved, this unfortunately will be blocked (as I don't want to get into managing/storing secrets myself).

[jasonwilliams]

no problem, thanks for raising upstream @eamodio @RMacfarlane !

[jasonwilliams]

Hey @eamodio microsoft/vscode#112043 has now been fixed and merged

[jasonwilliams]

This might be useful, the PR @kabel did to make use of the new enterprise provider in Github Pull Requests Extension - microsoft/vscode-pull-request-github#2468

[kglickman]

This feature has been working fine for me for months and suddenly stopped working. I think something may have gotten broken in VSCode version 1.62.3, though I haven't proven it yet. @eamodio Do you know anything about this?

[kglickman]

Yes, I have confirmed that it broke in 1.62.3. I've downgraded to 1.62.2 and it works again. Can you please pursue with VSCode since you understand the authentication mechanism and I do not? I think the fix for this defect is a likely candidate for the breaking change.

[TheSharpieOne]

I am running into this same issue with 1.62.3. As for also is there a way to reset this? You can go to "Manage Trusted Extensions" from the "Accounts" button (above the settings widget) at the bottom left then hover over your github name. It will open a menu allowing you to deselect extensions that have access.

[jasonwilliams]

@kglickman @TheSharpieOne is this still broken?

[jasonwilliams]

Unfortunately this is an issue with the VS Code auth provider: microsoft/vscode#112043

Until that issue is resolved, this unfortunately will be blocked (as I don't want to get into managing/storing secrets myself).

@eamodio I don't think this needs the "blocked" tags anymore as microsoft/vscode#112043 has been resolved for quite some time. (via microsoft/vscode#115940)

[kglickman]

This is working for me again in VSCode 1.64.0 but I have not gone back to figure out when it was fixed.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.