Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to authenticate with github enterprise #1755

Closed
dave-hart opened this issue May 5, 2020 · 10 comments
Closed

Unable to authenticate with github enterprise #1755

dave-hart opened this issue May 5, 2020 · 10 comments

Comments

@dave-hart
Copy link

dave-hart commented May 5, 2020

My current vscode workspace has an enterprise github project open, but the github pull requests plugin authenticates me with GitHub.com rather than my enterprise server.

I have been using the extension for a number of months with no problems, but when opening vscode yesterday I was prompted to authenticate, and have thus far been unable to get it to authenticate with my enterprise server.

I have followed the instructions in this wiki https://github.com/Microsoft/vscode-pull-request-github/wiki but the command mentioned to manually add an access token no longer seems to exist.

  • Extension version: 0.16.0
  • VSCode Version: 1.45.0-Insider
  • OS: MacOs
  • GitHub Enterprise Version: 2.19.8

Steps to Reproduce:

  1. Open vscode
  2. Select GitHub Pull Requests App
  3. Click to authenticate
  4. Complete the Github authentication flow in the resulting browser window, giving permission
@v-vazquez
Copy link

They removed the support because they don't have servers... What ...

https://github.com/Microsoft/vscode-pull-request-github/wiki

@sasikumardr
Copy link

sasikumardr commented May 8, 2020

Workaround for now is to downgrade to extension version 0.15

From Wiki

If you would still like to use the extension, you can use the "Install Another Version" option from the extensions viewlet to download version 0.15.0: microsoft/vscode#12764 (comment)

@KnisterPeter
Copy link

I'm really sad about this 😢

@erihanse
Copy link

erihanse commented May 8, 2020

Shouldn't this have been mentioned in the changelog atleast?

@5macro
Copy link

5macro commented May 8, 2020

Is there any chance to config the enterprise host and its token as follows?
image
I tried but it doesn't work...

@tk3369
Copy link

tk3369 commented May 9, 2020

Seems counter-intuitive that a paying customer is getting fewer features...

@sasikumardr
Copy link

This is not github's offering. As far as vscode team's concern, they are just helping vscode community with some useful extensions. As they mentioned in wiki, they have some technical and resource challenges for providing support for GitHub enterprise.
May be we should help creating PRs for adding this support rather than expecting everything from dev team.

@tk3369
Copy link

tk3369 commented May 10, 2020

That's fair... but Microsoft owns GitHub. I guess I'm expecting a little more :-)

The wiki says:

This iteration we moved to a new method of authentication built into VSCode in an effort to unify authentication and account management, and this API currently doesn't support Enterprise accounts.

It's unclear how to contribute PR. Maybe there's a better write-up somewhere about the challenge...

@ggcatu
Copy link

ggcatu commented May 11, 2020

Wow, this is really a shame, I use this extension daily for github enterprise, I wouldn't mind contributing to this..

That's fair... but Microsoft owns GitHub.

Maybe that's the problem ? :P

Anyway it mentions

Integrated sign in If your GitHub Enterprise is version 2.14.5 and above, you can authenticate in the same way as you would on GitHub, by clicking on the Sign In button when the dialog asking you to sign in shows up on the bottom right corner.
But I'm still not able to proceed with this... any idea ?

Also tried using the token but I get

image

@RMacfarlane
Copy link
Contributor

Closing as a duplicate of #1793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants