Add feature to close tabs with the middle mouse button #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolivav
commented
Oct 6, 2021
src/DockWidgetTab.cpp
Outdated
| { | ||
| d->saveDragStartMousePosition(internal::globalPositionOf(event)); | ||
| d->startFloating(DraggingInactive); | ||
| if (event->button() == Qt::LeftButton) { |
There was a problem hiding this comment.
Double click would trigger while closing tabs very fast, I don't think it was intended to float with any button anyway.
rolivav
commented
Oct 6, 2021
| if (CDockManager::testConfigFlag(CDockManager::MiddleMouseButtonClosesTab)){ | ||
| // Only attempt to close if the mouse is still | ||
| // on top of the widget, to allow the user to cancel. | ||
| if (rect().contains(mapFromGlobal(QCursor::pos()))) { |
There was a problem hiding this comment.
Can't use underMouse() because the flag is not properly updated.
rolivav
force-pushed
the
ff/editor/dev/middle_mouse_button_close
branch
from
806f566 to
7e5fb9e
Compare
|
Thank you |
luelista
pushed a commit
to luelista/Qt-Advanced-Docking-System
that referenced
this pull request
Mar 22, 2022
…FFFF#360) Co-authored-by: Rodrigo Oliva <Rodrigo.Oliva@king.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small feature to be able to close the tabs with the middle mouse button.
It is just faster and I missed it.