Automatically detect a remote that is not called "origin" so that users don't have to enter the remote name manually #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t remote regardless of name so that the user does not have to enter it manually. Co-authored-by: Liela Rotschy <lrotschy@github.com>
KetchupOnMyKetchup
changed the title
KetchupOnMyKetchup
deleted the
ketchup-lrotschy/automaticallyGetNonOriginRemote
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #121
If remote cannot find "origin", then automatically try to get the next remote regardless of name so that the user does not have to enter it manually.
The reason this did not work before is that
originwas keyed into thegetRemoteName()method:And the filter on line 70 was only checking for
origin:So if it did not find it, then it just returned undefined and the user had to set the remote manually. I think that it makes sense to search for origin first, but then to automatically grab any other existing remote if possible.
Before fix:
After fix:
Co-authored by @lrotschy