Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work if the GitHub remote is not called origin #121

Closed
qc00 opened this issue Apr 15, 2023 · 9 comments · Fixed by #160
Closed

Does not work if the GitHub remote is not called origin #121

qc00 opened this issue Apr 15, 2023 · 9 comments · Fixed by #160
Assignees
Labels
bug Something isn't working

Comments

@qc00
Copy link

qc00 commented Apr 15, 2023

To Reproduce
Steps to reproduce the behavior:

  1. Clone GitHub repo and open in VS Code
  2. Verify GitHub extensions work
  3. git remote rename origin fork
  4. Reload Window/restart app
  5. Verify other GitHub extensions like PR still work
  6. Actions extension displays: no GitHub repositories found

Expected behavior
The Actions extension continues to work (like the other extensions from GitHub) or provides an option to select a remote.

Extension Version
v0.25.5

@muzimuzhi
Copy link

typo in issue title: "if the GitHub branch is not called origin" -> "if the Git remote is not called origin"

@qc00 qc00 changed the title Does not work if the GitHub branch is not called origin Does not work if the GitHub remote is not called origin Apr 15, 2023
@muzimuzhi
Copy link

Looks like for now you have to change config github-actions.remote-name per (vscode) project by hand.
image

@qc00
Copy link
Author

qc00 commented Apr 15, 2023

That worked. Thanks!

Ideally, this can be detected automatically like the other GitHub extensions

@muzimuzhi
Copy link

A list of remote names could be provided but user still need to make a choice if multiple remotes exist and several of them are cloned from github.

@qc00 qc00 closed this as completed Apr 16, 2023
@github-project-automation github-project-automation bot moved this from Backlog 🗒 to Done 💤 in GitHub Actions VS Code Extension Apr 16, 2023
@muzimuzhi
Copy link

A list of remote names could be provided but user still need to make a choice if multiple remotes exist and several of them are cloned from github.

I mean, in simple cases yes the remote could be automatically used, but in more general cases there might be multiple qualified remotes (typically an upstream and a fork). In the latter case perhaps the extension could provide an easier way to switch between remotes.

@max-sixty
Copy link

I hit this in #96.

I'm surprised this requires manually configuration, particularly since often the correct remote will be upstream while the fork will be origin. Is my experience different from others'?

The message is also very non-obvious (particularly since origin was a GH repo, even if it wasn't one that runs GH Actions):

image

Currently this is the only extension I need to configure for each project individually. A rule like "Try origin, if that doesn't work, try the other one" would catch most cases.

@qc00
Copy link
Author

qc00 commented Apr 19, 2023

I was thinking of raising a separate enhancement ticket, but I now feel this is really a bug

@qc00 qc00 reopened this Apr 19, 2023
@github-project-automation github-project-automation bot moved this from Done 💤 to In progress 🚧 in GitHub Actions VS Code Extension Apr 19, 2023
@KetchupOnMyKetchup KetchupOnMyKetchup moved this from In progress 🚧 to Triaged 📝 in GitHub Actions VS Code Extension Apr 20, 2023
@KetchupOnMyKetchup KetchupOnMyKetchup moved this from Triaged 📝 to In progress 🚧 in GitHub Actions VS Code Extension May 1, 2023
@KetchupOnMyKetchup KetchupOnMyKetchup moved this from In progress 🚧 to Needs review 🤔 in GitHub Actions VS Code Extension May 1, 2023
@KetchupOnMyKetchup KetchupOnMyKetchup moved this from Needs review 🤔 to Needs to be merged 🎉 in GitHub Actions VS Code Extension May 2, 2023
@github-project-automation github-project-automation bot moved this from Needs to be merged 🎉 to Done 💤 in GitHub Actions VS Code Extension May 3, 2023
@KetchupOnMyKetchup KetchupOnMyKetchup moved this from Done 💤 to Pending Release 🥚 in GitHub Actions VS Code Extension May 3, 2023
@KetchupOnMyKetchup
Copy link
Contributor

The PR has been completed and the fix will be available in our upcoming release v0.25.7, which planned for release May 5, 2023. Thanks so much for submitting great bugs and feedback to help make the extension even better!

@KetchupOnMyKetchup
Copy link
Contributor

The fix has been released and is available in v0.25.7 🎉 !

@KetchupOnMyKetchup KetchupOnMyKetchup moved this from Pending Release 🥚 to Done 💤 in GitHub Actions VS Code Extension May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
5 participants