This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
Limit no-customized-built-in-elements
to built ins
#39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
no-customized-built-in-elements
to only error if the extended class is a value ofbuiltInTagMap
(exceptHTMLElement
, of course).The main motivation behind this work is extending a class that itself extends
HTMLElement
, without the complexity of static analyzing.Alternatives
Alternatively to this PR, users could just turn this rule off, but would lose slight benefit.
We could also have an allowlist for this rule,
allowedSuperNames
, similar to #38Breaking changes
This may change the actual (not expected) behavior of no-customized-built-in-elements in slight ways