Merge pull request #39 from mbullington/built-in-elements-cross-ref

Limit `no-customized-built-in-elements` to built ins
github · Feb 11, 2022 · 7bed82c · 7bed82c
2 parents 911d30c + 216df45
commit 7bed82c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/rules/no-customized-built-in-elements.js b/lib/rules/no-customized-built-in-elements.js
@@ -1,4 +1,6 @@
 const s = require('../custom-selectors')
+const {builtInTagMap} = require('../tag-names')
+
 module.exports = {
   meta: {
     type: 'problem',
@@ -8,7 +10,11 @@ module.exports = {
   create(context) {
     return {
       [s.HTMLElementClass](node) {
-        if (node.superClass && node.superClass.name !== 'HTMLElement') {
+        if (
+          node.superClass &&
+          node.superClass.name !== 'HTMLElement' &&
+          Object.values(builtInTagMap).includes(node.superClass.name)
+        ) {
           context.report(node, 'Avoid extending built-in elements')
         }
       }

diff --git a/test/no-customized-built-in-elements.js b/test/no-customized-built-in-elements.js
@@ -7,7 +7,8 @@ ruleTester.run('no-customized-built-in-elements', rule, {
     {code: 'class SomeMap extends Map { }'},
     {code: 'class FooBarElement { }'},
     {code: 'class FooBarElement extends HTMLElement { }'},
-    {code: 'const FooBarElement = class extends HTMLElement { }'}
+    {code: 'const FooBarElement = class extends HTMLElement { }'},
+    {code: 'const FooBarElement = class extends HTMLRandomNotBuiltInElement { }'}
   ],
   invalid: [
     {