Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Windows fixes #369

Merged
merged 15 commits into from
Oct 9, 2020
Merged

Bulk Windows fixes #369

merged 15 commits into from
Oct 9, 2020

Conversation

chiedo
Copy link
Contributor

@chiedo chiedo commented Oct 9, 2020

Why:

Shipping numerous work by @jeffmcaffer in bulk to avoid waiting for multiple checks.

This also enables windows tests on github/docs so we can run windows tests against branches here manually.

Closes #351
Closes #348
Closes #319
Closes #312
Closes: #137

Check off the following:

@chiedo chiedo requested a review from a team as a code owner October 9, 2020 21:14
@chiedo chiedo changed the title Bulk windows fixes 1602277955 Bulk Windows fixes Oct 9, 2020
@chiedo chiedo closed this Oct 9, 2020
@chiedo chiedo reopened this Oct 9, 2020
@chiedo
Copy link
Contributor Author

chiedo commented Oct 9, 2020

Tested it here on Windows by manually running the workflow: https://github.com/github/docs/runs/1233548947?check_suite_focus=true.

The only test that failed was a non-windows specific test on lint-ing so this is good to go!

@chiedo
Copy link
Contributor Author

chiedo commented Oct 9, 2020

Closes #351 #348 #319 #312

Copy link
Member

@JamesMGreene JamesMGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. ✨

Thank you @jeffmcaffer and @chiedo! 💝

@Octomerger Octomerger merged commit 67021f3 into main Oct 9, 2020
@Octomerger Octomerger deleted the bulk-windows-fixes-1602277955 branch October 9, 2020 22:21
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

@chiedo chiedo removed the autosquash label Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests may be broken on Windows
5 participants