Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix up redirect paths for Windows #348

Closed
wants to merge 1 commit into from
Closed

fix up redirect paths for Windows #348

wants to merge 1 commit into from
+3 −2

Conversation

jeffmcaffer
Copy link
Contributor

Why:

resolves: #313

What's being changed:

wrap path.join with slash() calls

Check off the following:

@jeffmcaffer jeffmcaffer added bug An error or flaw that causes unintended or unexpected results engineering Will involve Docs Engineering labels Oct 9, 2020
@jeffmcaffer jeffmcaffer requested a review from chiedo October 9, 2020 15:25
@jeffmcaffer jeffmcaffer requested a review from a team as a code owner October 9, 2020 15:25
heiskr
heiskr approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏼 Thanks!

@chiedo chiedo mentioned this pull request Oct 9, 2020
Merged
4 tasks
@chiedo chiedo deleted the jeffmcaffer-patch-4 branch November 30, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiskr heiskr heiskr approved these changes

@chiedo chiedo Awaiting requested review from chiedo

Assignees
No one assigned
Labels
bug An error or flaw that causes unintended or unexpected results engineering Will involve Docs Engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redirects incorrectly computed on Windows
2 participants
@jeffmcaffer @heiskr