-
Notifications
You must be signed in to change notification settings - Fork 59.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify OIDC process for AWS #19657
Clarify OIDC process for AWS #19657
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
7752601
to
2488aef
Compare
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
@baolsen Thanks for opening an issue and PR! I made a slight edit to your original message to connect the issue to this PR. ⚡ I'll get this triaged for the team to take a look 👀 |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
bump |
@baolsen Thanks for checking in on this. It's on the board and a team member will be reviewing it soon. We appreciate your patience as we work through our backlog 💛 |
2488aef
to
59d2167
Compare
Branch was getting a bit stale, rebased. |
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good 👍 And adds more info to the Doc 📖
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some edits for docs style
...ent/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services.md
Outdated
Show resolved
Hide resolved
...ent/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services.md
Outdated
Show resolved
Hide resolved
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
Note about the "Check unallowed file changes" test: These changes have been approved by a member of the engineering team here: #19657 (review) |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
I've recently used the OIDC on AWS documentation and found it difficult to use. After some rummaging around the internet I managed to get a fully working example and expanded on the documentation in this PR accordingly.
Closes #19656
Relates to [#15324]
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:
Writer impact (This section is for GitHub staff members only):