Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC on AWS documentation improvement #19656

Closed
1 task done
baolsen opened this issue Aug 10, 2022 · 5 comments · Fixed by #19657
Closed
1 task done

OIDC on AWS documentation improvement #19656

baolsen opened this issue Aug 10, 2022 · 5 comments · Fixed by #19657
Labels
content This issue or pull request belongs to the Docs Content team

Comments

@baolsen
Copy link
Contributor

baolsen commented Aug 10, 2022

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services

What part(s) of the article would you like to see updated?

IAM policy currently only shows a snippet and should have a full almost-working example

Additional information

No response
@baolsen baolsen added the content This issue or pull request belongs to the Docs Content team label Aug 10, 2022
@welcome
Copy link

welcome bot commented Aug 10, 2022

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 10, 2022
@baolsen baolsen mentioned this issue Aug 10, 2022
Merged
5 tasks
@baolsen
Copy link
Contributor Author

baolsen commented Aug 10, 2022

I've submitted a PR, the build is failing because it is modifying restricted files.
However this issue requires those files to be modified... Happy for suggestions

@baolsen
Copy link
Contributor Author

baolsen commented Aug 10, 2022

Relates to #15324

@cmwilson21
Copy link
Contributor

cmwilson21 commented Aug 10, 2022 •
edited
Loading

@baolsen Thanks for opening an issue and PR! 💖

@cmwilson21 cmwilson21 removed the triage Do not begin working on this issue until triaged by the team label Aug 10, 2022
@Eikyarkway

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify OIDC process for AWS baolsen/docs
4 participants
@baolsen @cmwilson21 @Eikyarkway and others