Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(webhooks-and-event-payloads): 'installation' property is always … #1948

Merged
merged 2 commits into from
Dec 10, 2020
Merged

docs(webhooks-and-event-payloads): 'installation' property is always … #1948

merged 2 commits into from
Dec 10, 2020

Conversation

oscard0m
Copy link
Contributor

@oscard0m oscard0m commented Dec 9, 2020

Why:

installation and installation_repository payloads have the property installation 100% of the times

Fix #516

What's being changed:

The following payloads have a more accurate description for installation property:

installation
installation_repositories

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@welcome
Copy link

welcome bot commented Dec 9, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@lucascosti lucascosti self-assigned this Dec 10, 2020
@lucascosti lucascosti added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Dec 10, 2020
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR, @dominguezcelada! This looks great, I'll get it merged 🚀

…n-payload-and-installation-repository-payload
@lucascosti lucascosti merged commit d18940b into github:main Dec 10, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@oscard0m oscard0m deleted the installation-property-always-for-installation-payload-and-installation-repository-payload branch December 10, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do installation and installation_repository payloads have the property installation 100% of the times?
2 participants