-
Notifications
You must be signed in to change notification settings - Fork 62.9k
Closed
Labels
ecosystemThis issue or pull request should be reviewed by the Docs Ecosystem teamThis issue or pull request should be reviewed by the Docs Ecosystem teamtriageDo not begin working on this issue until triaged by the teamDo not begin working on this issue until triaged by the team
Description
What article on docs.github.com is affected?
What part(s) of the article would you like to see updated?
Additional information
docs/content/developers/webhooks-and-events/webhook-events-and-payloads.md
Lines 446 to 448 in d516858
{% data reusables.webhooks.installation_properties %} | |
{% data reusables.webhooks.app_desc %} | |
{% data reusables.webhooks.sender_desc %} |
and
docs/content/developers/webhooks-and-events/webhook-events-and-payloads.md
Lines 470 to 472 in 20fa34e
{% data reusables.webhooks.installation_repositories_properties %} | |
{% data reusables.webhooks.app_desc %} | |
{% data reusables.webhooks.sender_desc %} |
Checking the description of installation
property, it denotes it could exist or not:
`installation` | `object` | The {% data variables.product.prodname_github_app %} installation. Webhook payloads contain the `installation` property when the event is configured for and sent to a {% data variables.product.prodname_github_app %}. |
but due to the nature of the events, it should always have installation
property right?
Context:
@octokit/webhook-definition
is working to improve typing of installation property in Payloads so it becomes an optional property (when necessary)
gr2m
Metadata
Metadata
Assignees
Labels
ecosystemThis issue or pull request should be reviewed by the Docs Ecosystem teamThis issue or pull request should be reviewed by the Docs Ecosystem teamtriageDo not begin working on this issue until triaged by the teamDo not begin working on this issue until triaged by the team