Update about-the-dependency-graph.md #17112

rukasakurai · 2022-04-15T09:13:53Z

NuGet is the package manager for .NET
C++ is not a .NET language

Why:

Inaccurate information on "About the dependency graph" page "Supported package ecosystems" section

Closes #17111

What's being changed:

Package manager for .NET to NuGet
Removing C++ from the list of .NET languages

- NuGet is the package manager for .NET - C++ is not a .NET language

welcome · 2022-04-15T09:13:55Z

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

github-actions · 2022-04-15T09:15:01Z

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source	Preview	Production	What Changed
content/code-security/supply-chain-security/understanding-your-software-supply-chain/about-the-dependency-graph.md	Modified	Original

ramyaparimi · 2022-04-15T14:05:09Z

@rukasakurai
Thanks so much for opening a PR! I'll get this triaged for review ⚡

SMAKSS

I guess NuGet is only one of the options and we also do have .NET CLI for managing all the .NET application tools.

github-actions · 2022-04-18T14:16:55Z

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

SIkebe · 2022-04-18T15:08:36Z

Hi @rukasakurai , I raised a similar PR (#17110) a few hours before this one 😄
I'm not very familiar with C++, but NuGet supports C++ according to some docs.

What programming languages are supported by NuGet?
NuGet generally works for .NET languages and is designed to bring .NET libraries into a project. Because it also supports MSBuild and Visual Studio automation in some project types, it also supports other projects and languages to various degrees.

The most recent version of NuGet supports C#, Visual Basic, F#, WiX, and C++.

https://docs.microsoft.com/en-us/nuget/resources/nuget-faq#what-programming-languages-are-supported-by-nuget-

NuGet for C++
https://devblogs.microsoft.com/cppblog/nuget-for-c/

SIkebe · 2022-04-18T15:21:18Z

I guess NuGet is only one of the options and we also do have .NET CLI for managing all the .NET application tools.

"NuGet" is the package manager. the NuGet client in Visual Studio, nuget.exe, and .NET CLI all implements NuGet Server API to do operations related to NuGet.
So "NuGet" is suitable here for package manager name.

SIkebe · 2022-04-18T15:23:37Z

...supply-chain-security/understanding-your-software-supply-chain/about-the-dependency-graph.md

@@ -66,7 +66,7 @@ The recommended formats explicitly define which versions are used for all direct
 | Package manager | Languages | Recommended formats | All supported formats |
 | --- | --- | --- | ---|
 | Composer             | PHP           | `composer.lock` | `composer.json`, `composer.lock` |
-| `dotnet` CLI | .NET languages (C#, C++, F#, VB)  |   `.csproj`, `.vbproj`, `.nuspec`, `.vcxproj`, `.fsproj` |  `.csproj`, `.vbproj`, `.nuspec`, `.vcxproj`, `.fsproj`, `packages.config` |
+| NuGet | .NET languages (C#, F#, VB)  |   `.csproj`, `.vbproj`, `.nuspec`, `.vcxproj`, `.fsproj` |  `.csproj`, `.vbproj`, `.nuspec`, `.vcxproj`, `.fsproj`, `packages.config` |


Is there any reason why you removed C++ and kept .vcxproj?

Thanks for noticing. I've added C++ back into the list of Langauges that NuGet supports, but outside of the () for .NET Languages, in which case there's no need to delete .vcxproj

but outside of the () for .NET Languages

Yeah, that should be fine👍 Thanks!

felicitymay · 2022-04-19T17:39:02Z

@rukasakurai and @SIkebe - many thanks for raising this problem with the docs ✨ and for your constructive discussion in this pull request 💖

We're checking on the reasons for the original content and will get back to you as soon as we can.

annarosenthal · 2022-04-20T15:09:08Z

Hi all, I'm an engineer on the Dependency Graph team and I can confirm that these proposed changes are accurate. Thank you for the update and links to support the update, @rukasakurai @SIkebe.

felicitymay

Many thanks for confirming that this is a good change @annarosenthal 💖

We'll merge this PR 🚀

github-actions · 2022-04-20T15:29:49Z

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Update about-the-dependency-graph.md

d0790a1

- NuGet is the package manager for .NET - C++ is not a .NET language

github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 15, 2022

ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review code security Content related to code security and removed triage Do not begin working on this issue until triaged by the team labels Apr 15, 2022

SMAKSS reviewed Apr 16, 2022

View reviewed changes

lecoursen added the needs SME This proposal needs review from a subject matter expert label Apr 18, 2022

lecoursen mentioned this pull request Apr 18, 2022

Fix package manager for .NET languages #17110

Closed

5 tasks

SIkebe reviewed Apr 18, 2022

View reviewed changes

Update about-the-dependency-graph.md

679783d

ramyaparimi added SME reviewed An SME has reviewed this issue/PR and removed needs SME This proposal needs review from a subject matter expert labels Apr 20, 2022

felicitymay approved these changes Apr 20, 2022

View reviewed changes

Merge branch 'main' into patch-2

9bc6d48

felicitymay enabled auto-merge (squash) April 20, 2022 15:26

felicitymay merged commit 25017a9 into github:main Apr 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update about-the-dependency-graph.md #17112

Update about-the-dependency-graph.md #17112

rukasakurai commented Apr 15, 2022 •

edited by ramyaparimi

Loading

welcome bot commented Apr 15, 2022

github-actions bot commented Apr 15, 2022 •

edited

Loading

ramyaparimi commented Apr 15, 2022

SMAKSS left a comment

github-actions bot commented Apr 18, 2022

SIkebe commented Apr 18, 2022

SIkebe commented Apr 18, 2022

SIkebe Apr 18, 2022

rukasakurai Apr 19, 2022 •

edited

Loading

SIkebe Apr 19, 2022

felicitymay commented Apr 19, 2022

annarosenthal commented Apr 20, 2022

felicitymay left a comment

github-actions bot commented Apr 20, 2022

Update about-the-dependency-graph.md #17112

Update about-the-dependency-graph.md #17112

Conversation

rukasakurai commented Apr 15, 2022 • edited by ramyaparimi Loading

Why:

What's being changed:

welcome bot commented Apr 15, 2022

github-actions bot commented Apr 15, 2022 • edited Loading

Automatically generated comment ℹ️

Content directory changes

ramyaparimi commented Apr 15, 2022

SMAKSS left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 18, 2022

SIkebe commented Apr 18, 2022

SIkebe commented Apr 18, 2022

SIkebe Apr 18, 2022

Choose a reason for hiding this comment

rukasakurai Apr 19, 2022 • edited Loading

Choose a reason for hiding this comment

SIkebe Apr 19, 2022

Choose a reason for hiding this comment

felicitymay commented Apr 19, 2022

annarosenthal commented Apr 20, 2022

felicitymay left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 20, 2022

rukasakurai commented Apr 15, 2022 •

edited by ramyaparimi

Loading

github-actions bot commented Apr 15, 2022 •

edited

Loading

rukasakurai Apr 19, 2022 •

edited

Loading