Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package manager for .NET languages #17110

Closed
wants to merge 1 commit into from
Closed

Conversation

SIkebe
Copy link
Contributor

@SIkebe SIkebe commented Apr 15, 2022

Why:

dotnet CLI is not a package manager, NuGet is the correct one. Also dotnet CLI supports only .NET Core/.NET and does not support .NET Framework. AFAIK, dependabot should support .NET Framework projects.

What's being changed:

Package manager name: dotnet CLI -> NuGet

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 15, 2022
@github-actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/code-security/supply-chain-security/understanding-your-software-supply-chain/about-the-dependency-graph.md Modified Original

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review code security Content related to code security and removed triage Do not begin working on this issue until triaged by the team labels Apr 15, 2022
@ramyaparimi
Copy link
Contributor

@SIkebe
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@lecoursen
Copy link
Member

Hi there! We have another PR very similar to this one, #17112, but with an additional change, so I'm going to close this one and have the team review the other instead. Thanks for your interest in contributing to our docs!

@lecoursen lecoursen closed this Apr 18, 2022
@SIkebe
Copy link
Contributor Author

SIkebe commented Apr 18, 2022

@lecoursen Hmm, #17112 seems to include wrong changes. I'll comment in the PR.

@SIkebe SIkebe deleted the patch-4 branch April 18, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code security Content related to code security content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants