-
Notifications
You must be signed in to change notification settings - Fork 60.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniform ed25519 usage across SSH docs #1105
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
I missed this one, sorry about that @jezhou8! I'll get this triaged for review ✨ |
Hello @jezhou8! Thank you for proposing a pull request for fixing this problem. We're really grateful for the help we've been receiving from the community 💟 Your fix was totally right, but we had a slightly earlier pull request (#1074) that fixed the same issue, so I'm going to close this pull request ✔️ Thank you again for contributing 😊 |
Why: I was trying to add a new ssh key and noticed that github now accepts the more secure ed25519 encryption standard! However, in the documentation, some parts of the tutorial still used referenced the old RSA steps. So I wanted to help make the documentation more uniform and use ed25519.
What's being changed:
Check off the following: