Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update adding-a-new-ssh-key-to-your-github-account.md #1063

Merged
merged 5 commits into from
Nov 23, 2020
Merged

Update adding-a-new-ssh-key-to-your-github-account.md #1063

merged 5 commits into from
Nov 23, 2020

Conversation

brockneedscoffee
Copy link
Contributor

The updated docs that use ed25519 to generate the key are merged. This needs to match those steps

Why:

The updated docs introduce in this PR now make these steps incorrect, this just updates the steps to match the key generation now the guidance no longer uses rsa

What's being changed:

I updated the copy step to read:

pbcopy < ~/.ssh/id_ed25519.pub

Check off the following:

@brockneedscoffee
Update adding-a-new-ssh-key-to-your-github-account.md
45b978b 
The updated docs that use ed25519 to generate the key are merged.  This needs to match those steps
@welcome
Copy link

welcome bot commented Nov 4, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

This was referenced Nov 5, 2020
Closed
Closed
@janiceilene
Copy link
Contributor

Thanks for catching that and opening a PR @brockneedscoffee! I'll get this triaged for review 🎉

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Nov 6, 2020
@janiceilene janiceilene mentioned this pull request Nov 6, 2020
Merged
4 tasks
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 14, 2020
@brockneedscoffee
Copy link
Contributor Author

@janiceilene any updates on this?

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Nov 20, 2020
shati-patel
shati-patel previously requested changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request, @brockneedscoffee! We appreciate the help 🎉

There are a few other places in this file where id_rsa appears. For consistency, could you also update those? I've added one of them as a suggestion, but there are 4 more further down in the file (in the Windows/Linux sections).

Once you've done that, we can get this merged! Thank you again for you contribution 😊

content/github/authenticating-to-github/adding-a-new-ssh-key-to-your-github-account.md Outdated Show resolved Hide resolved
@shati-patel shati-patel self-assigned this Nov 20, 2020
shati-patel and others added 3 commits November 20, 2020 19:38
@shati-patel
Merge branch 'main' into patch-1
ee8dd37
@felicitymay @shati-patel
Update content/github/authenticating-to-github/adding-a-new-ssh-key-t…
649368c 
…o-your-github-account.md

Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
@felicitymay
Merge branch 'main' into patch-1
59fbffc
felicitymay
felicitymay approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@felicitymay felicitymay left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the reviewer that it would be better to update all the instances of id_rsa in this topic, but there are other problems with this topic that need to be fixed to make it usable. So I'm going to merge this as-is.

@felicitymay felicitymay dismissed shati-patel’s stale review November 23, 2020 18:48

The changes have been committed

@felicitymay felicitymay merged commit b8aea4d into github:main Nov 23, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Octomerger pushed a commit that referenced this pull request Oct 25, 2021
@peterbe
Fix Failbot sending auth (#22396)
791b661 
Part of #1063
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@JamesGuthrie
Remove duplicate "add GPG key" instruction (github#1063)
e439db8 
In the debian install documentation the instruction to add the timescale
GPG key was duplicated, once before adding the repository, and once
after. This doesn't cause any issues, but is unnecessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felicitymay felicitymay felicitymay approved these changes

@shati-patel shati-patel shati-patel left review comments

Assignees

@shati-patel shati-patel

Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brockneedscoffee @janiceilene @felicitymay @shati-patel