Failed upload leaks credentials

[bndw]

First, thanks for providing a simple tool for working with Github releases!

It appears that when using the upload command to a non-existent repository, the access_token is leaked in the error message. This is a problem when running this tool in an open-source project's CI system.

bin/linux/amd64/github-release
error: expected '200 OK' but received '404 Not Found' (url: https://api.github.com/repos/envoy-bot/envoy/releases?access_token=MY_ACCESS_TOKEN&per_page=100)

[jc21]

In addition to this, the access token should not be in the URL as it is deprecated. Github sent me a message about this today.

Since the project looks dead, looks like I'll be using one of the forks and if they don't fix this, I'll be forking the fork..

[alertedsnake]

In addition to this, the access token should not be in the URL as it is deprecated. Github sent me a message about this today.

Since the project looks dead, looks like I'll be using one of the forks and if they don't fix this, I'll be forking the fork..

@jc21 did you fork the fork? I need this fix as well :)

[kevinburke1]

I thought I fixed this... is it not fixed?

[ocdtrekkie]

It's worth noting the official gh tool supports release management now, depending on your situation, switching to the official tool may be a good option now.

In my case, I found https://cli.github.com/manual/gh_release_create a perfectly serviceable replacement.

[alertedsnake]

@ocdtrekkie I just noticed that myself! So disregard my comments here, I'll use their tool instead.

[kevinburke1]

apologies for the delay; I've just merged the fix