Remove use of github-release #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
sdurrheimer
approved these changes
Apr 18, 2019
|
I tested with a repository of mine and it worked ok (including overwriting assets). I was wondering whether the
No problem! |
|
I'd say so for draft releases. Saves manually removing them when there's a
failure half way through.
…On Thu 18 Apr 2019, 16:55 Simon Pasquier, ***@***.***> wrote:
I tested with a repository of mine and it worked ok (including overwriting
assets). I was wondering whether the --overwrite flag is even needed,
maybe it is fine to always overwrite the assets for draft releases.
Anyway, thanks for working on that. I wanted to do it a long time ago but
didn't manage to actually work on it.
No problem!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#136 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABWJG5S33QDTHTDHKPDXHY3PRCDVTANCNFSM4HGTULPQ>
.
|
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
|
I've updated the PR so it will overwrite any asset file if the release is a draft. |
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been found that the github-release program can leak credentials in the logs when it encounters an error. The upstream project itself isn't maintained actively, the original author recommends one of the forks but 1) it has the same issue and 2) it doesn't offer release binaries.
Looking at we needed from github-release, it isn't that complicated to use directly the GitHub API client instead of relying on an external program.
Closes #4.
Relates to #28 #26