-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename MediaWiki to Wikitext #5295
Conversation
This might cause problems with Bear in mind that Linguist and Markup are two entirely separate pieces of software, and two different teams of people at GitHub are responsible for maintaining them. Or should I say, only one team.
Long-winded explanation unrelated to this PRWhen you delete a branch—either locally or on GItHub—the comments that referenced it still linger on in Git's object-tree (until they're garbage-collected). In fact, a branch is little more than a pointer to a commit object. Each commit holds a link to the one that came before it (the so-called “parent“ commit), so the entire history remains intact. And yes, that's bad news if you accidentally publish sensitive data. On the other hand, it can also be a lifesaver if you later regret deleting a branch with a detailed history. Provided, of course, you know the hash of the last commit. This happened to me with I'm still stuck on how to recover the missing week between file-icons/atom@c5ee547 and the final merge-commit. 😞 @lildude, any chance you're able to help here? |
🤔 ffb9330 is the commit where things went "wrong". Three shas are involved:
GitHub only knows about the middle one (current master HEAD), but not the other two (your change which moved the entry down and the final resulting merge commit) which is likely to be in the branch you deleted. As you've force-pushed to GitHub using the same branch name, you'll need to trawl your local clone to find the original commits. You can probably find these using As for ...
This is a good point and I have absolutely no idea how this rename would impact things; I know very little about that repo and how it applies to GitHub.com. |
@lildude Just in case you missed it, I pinged you in my earlier comment:
|
@Alhadis I think the same method could work here too if you've still got the original repo locally. Things like |
Unfortunately, I don't. :sad I definitely would've dug out dangling objects if they were in my local checkout. As for the commit I did I manage to recover, I did so after several years had passed, which convinces me there might be a reference to it somewhere (possibly from some user's fork). I'm wondering if dangling commits are included with the huge archive GitHub sends you when you request a copy of your data... |
Can I just |
That would probably work. If you've still got your original local clone, you could probably fix things using: $ git revert 9a1f0cad8e7efb4b224feb730e09bc0e99cd3165
$ git cherry-pick 7b2f8caeba53d2fc67693efa729fb6f6afe1eb7b ... and then correct the name as 7b2f8caeba53d2fc67693efa729fb6f6afe1eb7b only moves the section. |
Added extension |
I've looked into the markup code and I think we should be OK with this rename because we're keeping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested and we look to be good to merge this. All three of the files in this gist render correctly when I test with these changes in place. For those looking at this later, the last file doesn't currently render.
So nothing is broken and we gain wiki rendering of .wikitext
files 🎉
Wikitext is the main name of the syntax; MediaWiki is the wiki software itself.
Add extension
.wikitext
: search results (31K+)