Remove yarn.lock from auto-generated files list (follow-up) #4459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Alhadis
approved these changes
Mar 13, 2019
|
Thanks! This was my blunder... 😓 |
Merged
|
Many thanks :-) |
|
@Alhadis Hmmm, merging this whilst the release PR was pending has caused a bit of a complication WRT the versions and contents 😞 I'm going to need to get a bit creative to get this into v7.3.1 |
lildude
added a commit
that referenced
this pull request
Mar 13, 2019
lildude
added a commit
that referenced
this pull request
Mar 13, 2019
|
Sorry about that. :/ If I'd known that it wasn't possible to squeeze in last minute changes, I wouldn't have been so quick to merge. |
Merged
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #4445, which intended to make
yarn.lockno longer be treated as an auto-generated file (to fix #4348), however only removed the tests rather than also the handling ingenerated.rb.As of this PR, b36ea7a is now fully reverted.
Fixes #4348.