Unconditionally Generate Bindless Samplers in DX12 #6766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
changed the title
cwfitzgerald
force-pushed
the
cw/dx12-sampler-bindless
branch
3 times, most recently
from
1564ef7 to
80bcb42
Compare
cwfitzgerald
force-pushed
the
cw/dx12-sampler-bindless
branch
2 times, most recently
from
1ec761b to
6b4b92c
Compare
cwfitzgerald
force-pushed
the
cw/dx12-sampler-bindless
branch
3 times, most recently
from
d740d53 to
f0646c9
Compare
|
@cwfitzgerald it looks like there are some conflicts, could you rebase the PR? |
|
Yeah I was just waiting for a review first, but if you want a rebase I can |
|
It looks like it includes #6847 but with some differences so it makes it hard to look at the diff. |
|
Oh yes - let me refactor that away |
cwfitzgerald
force-pushed
the
cw/dx12-sampler-bindless
branch
from
f0646c9 to
f14ad9e
Compare
|
Sorry took a minute, good to go now. |
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Closes #3350
Depends on #6847
This PR should be reviewed commit by commit.
Description
We go bindless on our samplers yo