Move the trace recording of destroy events out of triage_resources #5036
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves all of the
trace::Action::DestroyFoo(id)
out oftriage_resource
. The main motivation is to avoid holding the trace lock for a long time and let the resourcedrop
impls take that lock without risking deadlocks if the reference count happens to go to zero during triage.This will allow us to remove the
free_resource
tracker in a followup which is needed for #4917.Incidentally I'm happy about how it simplifies the code. It makes sense for this stuff to be handled by the resources themselves instead of the lifecycle triaging code which in an ideal world wouldn't need to do resource-specific logic.
triage_resource
does not need to take anon_remove
callback anymore.Checklist
cargo fmt
.cargo clippy
.cargo xtask test
to run tests.