Remove more internal uses of IDs #2 #5871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoxoy
force-pushed
the
remove-more-uses-of-ids-2
branch
from
5f8b9d7 to
a8a82e2
Compare
ErichDonGubler
approved these changes
Jun 24, 2024
|
praise: Also, can I just say that the individual relatively small commits made review zoom for me? 😀 |
nical
reviewed
Jun 25, 2024
we already trace buffer drop and destroy in the corresponding `Global` methods so we might end up with double drop/destroy actions
we already trace texture view and bind group drop in the corresponding `Global` methods so we might end up with double drop actions
teoxoy
force-pushed
the
remove-more-uses-of-ids-2
branch
from
a8a82e2 to
395c49a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5121.
PR doesn't need to be squashed, each commit builds by itself.