Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow vulkan to change view formats #3399

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

cwfitzgerald
Copy link
Member

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.

Connections

Follow up to #3237

cc @jinleili

Description

Adding view format changing as a downlevel flag was missed on the original PR, so an extra bit of data wasn't passed down to vulkan.

Testing

Tested using the view format aliasing test, thanks for that test!

@codecov-commenter
Copy link

Codecov Report

Merging #3399 (b420759) into master (cecf063) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3399      +/-   ##
==========================================
- Coverage   65.09%   65.09%   -0.01%     
==========================================
  Files          87       87              
  Lines       42968    42976       +8     
==========================================
+ Hits        27972    27976       +4     
- Misses      14996    15000       +4     
Impacted Files Coverage Δ
wgpu-hal/src/lib.rs 26.92% <ø> (ø)
wgpu-core/src/device/mod.rs 66.76% <100.00%> (+0.02%) ⬆️
wgpu-hal/src/vulkan/adapter.rs 78.59% <100.00%> (+0.01%) ⬆️
wgpu-hal/src/vulkan/device.rs 75.89% <100.00%> (+0.04%) ⬆️
wgpu-core/src/instance.rs 65.71% <0.00%> (-0.41%) ⬇️
wgpu-core/src/hub.rs 61.13% <0.00%> (-0.16%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ideally we'd also make use of VK_KHR_image_format_list but we can do that later, I'll open an issue.

@teoxoy teoxoy merged commit 2c3f9fa into gfx-rs:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants