Add view_formats in TextureDescriptor

[jinleili]

Checklist

• Run cargo clippy.
• Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
• Add change to CHANGELOG.md. See simple instructions inside file.

Connections
WebGPU spec: https://www.w3.org/TR/webgpu/#dom-gputexturedescriptor-viewformats

Description

Closes #3030

Testing
Tested on Metal, Vulkan(--features vulkan-portability) and Dx12 backend.

[codecov-commenter]

Codecov Report

Merging #3237 (8bbccdd) into master (4400ff8) will decrease coverage by 0.00%.
The diff coverage is 57.81%.

@@            Coverage Diff             @@
##           master    #3237      +/-   ##
==========================================
- Coverage   64.64%   64.63%   -0.01%     
==========================================
  Files          86       86              
  Lines       42722    42768      +46     
==========================================
+ Hits        27616    27645      +29     
- Misses      15106    15123      +17     

Impacted Files	Coverage Δ
wgpu-core/src/present.rs	0.00% <0.00%> (ø)
wgpu-core/src/resource.rs	25.13% <ø> (ø)
wgpu/src/lib.rs	51.04% <33.33%> (-0.03%)	⬇️
wgpu/src/backend/direct.rs	56.98% <40.00%> (+0.11%)	⬆️
wgpu-core/src/device/mod.rs	66.73% <57.14%> (-0.07%)	⬇️
wgpu-types/src/lib.rs	87.45% <60.52%> (-0.62%)	⬇️
wgpu-core/src/command/clear.rs	89.58% <100.00%> (ø)
wgpu-core/src/command/transfer.rs	75.14% <100.00%> (ø)
wgpu-core/src/init_tracker/texture.rs	93.65% <100.00%> (ø)
wgpu-core/src/hub.rs	60.98% <0.00%> (-0.16%)	⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[crowlKats]

Could the deno webgpu part be implemented fully/properly?

[cwfitzgerald]

Thank you for tackling this one!

The code is fine, but there are two extra parts we need (besides the deno stuff).

First can you add a test to make sure the feature works (read a unorm texture as srgb and validate it does the conversion - and vise versa)

We also need a downlevel feature for this, as gles doesn't support texture views. And afaik we can't polyfill this feature in any way.

[jinleili]

@crowlKats I'm sorry, I don't know how to properly implement view_formats in deno_webgpu. deno_webgpu's webgpu.idl doesn't have viewFormats field, is it enough to add viewFormats field to deno_webgpu::texture::CreateTextureArgs?

[crowlKats]

no, its slightly more than just that. but no worries, i will do it then

[khyperia]

Hi! I'm just a random user of wgpu, so take this whole comment with a grain of salt. Proper sRGB support in the webgpu backend of wgpu is blocked on specifying the view format of the Surface's current_texture (the swapchain image). In webgpu, this is done by setting GPUCanvasConfiguration.viewFormats to the formats you'd like to view the current_texture as, then specifying that format in create_view. (I guess this GPUCanvasConfiguration.viewFormats field is a sort of backdoor to pass in view_formats into the system's internal create_texture for the current_texture?)

https://www.w3.org/TR/webgpu/#canvas-configuration

In wgpu, the GPUCanvasConfiguration is created here, and I suppose mapped.view_formats() should be called, similar to what this PR is already doing in the device_create_texture function in web.rs

wgpu/wgpu/src/backend/web.rs

Lines 1037 to 1041 in aa46e82

	let mut mapped =
	web_sys::GpuCanvasConfiguration::new(&device.0, map_texture_format(config.format));
	mapped.usage(config.usage.bits());
	mapped.alpha_mode(alpha_mode);
	surface.0.configure(&mapped);

I suppose SurfaceConfiguration should get a new view_formats: Vec<TextureFormat> field, similar to how TextureDescriptor got that field in this current PR? I haven't looked into how other backends other than webgpu handle the view format of the surface current_texture, and if they support alternate views at all, and how they're configured/enabled.

If you could implement this in this PR or a followup, that would be amazing, but please ping me if you don't plan on doing so and I can try looking into implementing it!

[jinleili]

The implementation of this PR is not yet accepted and may need to be modified. I have plans to implement view_formats in SurfaceConfiguration after this PR.

[cwfitzgerald]

Another round, we're very close!

[cwfitzgerald]

Really good stuff, we're almost ready to go!

[cwfitzgerald]

Thank you for all the hard work!