Revert to rust 1.63 #3217
Closed
Revert to rust 1.63 #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3217 +/- ##
==========================================
+ Coverage 64.70% 65.26% +0.55%
==========================================
Files 81 81
Lines 38819 39479 +660
==========================================
+ Hits 25118 25764 +646
- Misses 13701 13715 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The following error variants were large enough to trip Clippy's `result_large_err` lint: - RenderPassCompatibilityError::IncompatibleColorAttachment - CreateShaderModuleError::Validation Large error types are a problem, because they make the `Result` type large, requiring the program to copy around large numbers of bytes even in the success case. Since the failure case is rare, it's usually not a problem to just heap-allocate the contents to keep the `Ok` case small.
jimblandy
force-pushed
the
revert-to-rust-1.63
branch
from
694eb09
to
8558a40
Compare
|
This depends on #3226. |
jimblandy
force-pushed
the
revert-to-rust-1.63
branch
from
8558a40
to
6ad7c42
Compare
|
We actually expect to update Firefox to 1.64 very soon, so this PR needs to be amended. We'd very much like to keep all the workspace inheritance changes. |
|
We don't need this much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox is still using an MSRV of 1.63, and wgpu currently uses 1.65.
The 1.64->1.65 jump is from #3184, which I merged. Egg on my face.
The 1.63->1.64 jump is from #3107.
We should have a comment in the top-level Cargo.toml about this, to catch this problem in the future.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Describe what problem this is solving, and how it's solved.
Testing
Explain how this change is tested.