Migrate to Rust 1.65 #3184
Merged
Migrate to Rust 1.65 #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoxoy
reviewed
Nov 7, 2022
|
Mmmm, looks like CI is failing because the |
Codecov Report
@@ Coverage Diff @@
## master #3184 +/- ##
=======================================
Coverage 64.73% 64.74%
=======================================
Files 81 81
Lines 38747 38748 +1
=======================================
+ Hits 25084 25088 +4
+ Misses 13663 13660 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ErichDonGubler
changed the title
clippy lints
|
Per conversation in Matrix with @cwfitzgerald, I've pushed d1682f9 (upgrading to Rust 1.65) and renamed this PR. Will autosquash momentarily, after CI turns green. |
cwfitzgerald
reviewed
Nov 7, 2022
ErichDonGubler
force-pushed
the
clippy
branch
4 times, most recently
from
c3e183c
to
e60b125
Compare
cwfitzgerald
reviewed
Nov 7, 2022
5 tasks
ErichDonGubler
force-pushed
the
clippy
branch
from
342b36e
to
d68428b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Add change to CHANGELOG.md. See simple instructions inside file.Opting not to do this, unless somebody thinks it's actually interesting for downstream.Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
None that I know of.
Description
Describe what problem this is solving, and how it's solved.
The Rust 1.65 toolchain has introduced several new lint warnings for this repository. Keep it clean by taking the most straightforward path for resolving lints. The only change that I think is controversial is the final change to appease
clippy::result_large_err, which adds a.clippy.tomlto set the lint threshold to right about our current largest case.Recommended review experience: commit-by-commit.
Testing
Explain how this change is tested.
It still compiles, so we should be good to go!