[dx12] Fix partial texture barrier not affecting stencil aspect #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix clearing of D24Plus also clearing "hidden" stencil
kvark
requested changes
Dec 20, 2021
Wumpf
force-pushed
the
dx12-fix-stencil-barrier-and-clear
branch
from
80c8e0f
to
e534d75
Compare
kvark
approved these changes
Dec 26, 2021
kvark
added
the
PR: needs back-porting
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Dec 29, 2021
…rs#2308) * [dx12] Fix partial texture barrier not affecting stencil aspect Fix clearing of D24Plus also clearing "hidden" stencil * [dx12] fix handling stencil only formats for clears & barriers
kvark
pushed a commit
that referenced
this pull request
Dec 29, 2021
* [dx12] Fix partial texture barrier not affecting stencil aspect Fix clearing of D24Plus also clearing "hidden" stencil * [dx12] fix handling stencil only formats for clears & barriers
|
published in wgpu-hal-0.12.1 |
kvark
removed
the
PR: needs back-porting
cwfitzgerald
pushed a commit
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Issues accidentally covered by tests in #2307 (i.e. this change is required to land it)
Description
Fix partial texture barrier (i.e. when not the entire texture is transitioned) not affecting stencil aspect.
Fix clearing of D24Plus also clearing "hidden" stencil.
Testing
Tested in #2307, a dedicated test would be nice to be fair but this will have to do for now