Add defaults to new limits and correct older ones #2303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
added
the
PR: needs back-porting
kvark
removed
the
PR: needs back-porting
cwfitzgerald
pushed a commit
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Note on Matrix about missing defaults
Description
This adds defaults to the new limits
max_inter_stage_shader_components,max_compute_workgroup_storage_sizeandmax_compute_invocations_per_workgroup, as all other limits had their default documented. Also, some incorrect (probably out-of-sync and one copy-paste error) default documentations have been corrected to match their actual value in theDefaultimplementation forLimits.Testing
As this is a doc-only change,
cargo docsucceeds.