support push constants on metal #2258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
requested changes
Dec 6, 2021
| @@ -592,7 +592,27 @@ impl crate::CommandEncoder<super::Api> for super::CommandEncoder { | |||
| _offset: u32, | |||
| _data: &[u32], | |||
| ) { | |||
| //TODO | |||
| if _stages.contains(wgt::ShaderStages::COMPUTE) { | |||
There was a problem hiding this comment.
This needs to be a tiny bit more complex.
The way it's supposed to work is if you have [u8; max_push_constants] array on the command encoder. set_push_constants would just overwrite some of these bytes, but the shaders would see as much as PipelineLayout have declared.
E.g. user could 0..4 with one set_push_constants and 4..8 with another call, and the shader needs to see all of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
fix #1825
Description
support push constants on metal. needed to run https://github.com/googlefonts/compute-shader-101/tree/main/rust-gpu-toy on macOS
I have no experience working with graphics API, so I don't know if the code in the PR is actually correct :-(
Testing
That repo above seems to run correctly.