Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshots: Consolidate path handling. #2501

Merged
merged 6 commits into from
Sep 25, 2023
Merged

snapshots: Consolidate path handling. #2501

merged 6 commits into from
Sep 25, 2023

Commits on Sep 25, 2023

  1. Delete output files no longer generated by snapshot tests.

    @jimblandy
    jimblandy committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    b530fd6 View commit details
    Browse the repository at this point in the history

  2. Give convert_glsl_folder's output more consistent names. 

    Don't replace dots with dashes in the output filenames for no reason.
Instead, give them names consistent with those generated by
`write_output_glsl`.
    @jimblandy
    jimblandy committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    3f4db6a View commit details
    Browse the repository at this point in the history

  3. Change naga::back::spv::DebugInfo::file_name to a &Path. 

    This makes it a bit easier to use in the CLI and snapshot tests.
    @jimblandy
    jimblandy committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    17b5290 View commit details
    Browse the repository at this point in the history

  4. snapshots: Name convert_glsl_variations_check output consistently. 

    Rather than adding a `-glsl` suffix to the name, just rely on
`check_targets`' standard naming behavior, treating
`tests/in/variations.glsl` like any other snapshot input.
    @jimblandy
    jimblandy committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    0cb94da View commit details
    Browse the repository at this point in the history

  5. snapshots: Consolidate path handling. 

    Add a new type, `Input`, representing a particular Naga input file,
with methods to generate related paths - output files with a
particular extension, parameter files, and the input file itself.
Use this throughout `snapshots.rs` to generate paths.

Give `Input` utility methods for reading and writing files.
    @jimblandy
    jimblandy committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    01fd6f3 View commit details
    Browse the repository at this point in the history

  6. snapshots: Change messages for generating output. 

    Change printlns in the backend functions to say "generating" instead
of "writing" before calling the Naga backends. "Writing" suggests
writing output to a file; "generating" seems more accurate for calling
a backend.
    @jimblandy
    jimblandy committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    f096f87 View commit details
    Browse the repository at this point in the history