snapshots: Consolidate path handling. #2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like this needs a manual rebase... |
Don't replace dots with dashes in the output filenames for no reason. Instead, give them names consistent with those generated by `write_output_glsl`.
This makes it a bit easier to use in the CLI and snapshot tests.
Rather than adding a `-glsl` suffix to the name, just rely on `check_targets`' standard naming behavior, treating `tests/in/variations.glsl` like any other snapshot input.
Add a new type, `Input`, representing a particular Naga input file, with methods to generate related paths - output files with a particular extension, parameter files, and the input file itself. Use this throughout `snapshots.rs` to generate paths. Give `Input` utility methods for reading and writing files.
Change printlns in the backend functions to say "generating" instead of "writing" before calling the Naga backends. "Writing" suggests writing output to a file; "generating" seems more accurate for calling a backend.
jimblandy
force-pushed
the
snapshot-param-reform
branch
from
c30e336
to
f096f87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new type,
Input, representing a particular Naga input file, with methods to generate related paths - output files with a particular extension, parameter files, and the input file itself. Use this throughoutsnapshots.rsto generate paths.Give
Inpututility methods for reading and writing files.Each commit in this PR should pass CI independently. Some commits have a lot of pure renames, so reviewing commits separately is probably easiest.