glsl-in: Perform output parameters implicit casts #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCapucho
force-pushed
the
glsl-out-casts
branch
2 times, most recently
from
157c13d
to
7bc7b79
Compare
teoxoy
approved these changes
Dec 2, 2022
|
Looks like there are some test conflicts, feel free to merge once resolved. |
jimblandy
requested changes
Dec 5, 2022
|
(I had this review sitting there since forever, and didn't realize I hadn't posted it) |
JCapucho
force-pushed
the
glsl-out-casts
branch
5 times, most recently
from
b3d2ee2
to
e260a5c
Compare
|
It looks like the log message on commit e260a5c isn't right. |
Oh no, seems like I did something that made git override the commit message with one of another commit that was merged by master (It also seems to have squashed commits 😞) |
JCapucho
force-pushed
the
glsl-out-casts
branch
2 times, most recently
from
1c1364c
to
f12409e
Compare
|
@jimblandy should be fixed and rebased |
Glsl defines under `Function Definitions` (Paragraph 6.1 in glsl 4.60), the following: > When function calls are resolved, an exact type match for all > the arguments is sought. > (...) > If no exact match is found, then the implicit conversions in > section “Implicit Conversions” will be applied to find a match. > (...) > Mismatched types on output parameters (out or inout) must have a > conversion from the formal parameter type to the calling argument type. The glsl frontend wasn't performing this implicit cast for output parameters. This commit fixes that by using a proxy write, this creates a spill variable with the correct type and in the call prologue a conversion is made back to the original type and the value is stored in the original variable.
JCapucho
force-pushed
the
glsl-out-casts
branch
from
f12409e
to
3d87400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rant: this is incredibly cursed and I wouldn't even believe this existed if I hadn't ran into a shader that used this.
Glsl defines under
Function Definitions(Paragraph 6.1 in glsl 4.60),the following:
The glsl frontend wasn't performing this implicit cast for output parameters.
They are now implemented trough a proxy write (like when swizzling for output parameters), where a spill variable with the correct type is passed and on the call prologue a conversion back to the original type is performed and the value stored in the original variable.
Furthermore if the variable in declared
inout, a conversion is also made in the call prelude from the original type to the correct type and the value is stored in the spill variable.