Bunch of fixes #420
Merged
Bunch of fixes #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pub prim_type: PrimitiveType, | ||
| /// Source of the vertex ordering when drawing. | ||
| pub kind: SliceKind, | ||
| } |
|
why does build fail |
| @@ -53,7 +53,7 @@ struct Params { | |||
| color: gfx::shade::TextureParam, | |||
| } | |||
|
|
|||
| static VERTEX_SRC: gfx::ShaderSource = shaders! { | |||
| static VERTEX_SRC: gfx::ShaderSource<'static> = shaders! { | |||
There was a problem hiding this comment.
This is getting more and more verbose... I wish we could simplify it.
|
r+, assuming you address my comments and fix Travis. |
Since the Device isn't behind a task anymore, these don't need to be owned ever. Closes gfx-rs#359
This removes `IndexCount`, as it will never be distinct from `VertexCount`, and cleans up the `Slice` representation to factor out common fields with names, because it was becoming unmanageable. Changes the `DrawCommand` slightly to take a buffer handle when binding the index buffer, because the size of the buffer is needed in the fallback for when base indexes are not supported. This code path should be very rare. First half of gfx-rs#355
There is no reason to wait, we are on the same thread as the device. Closes gfx-rs#299
adamnemecek
pushed a commit
to adamnemecek/gfx
that referenced
this pull request
Apr 1, 2021
416: Makefile package command and travis github releases r=kvark a=Korijn Closes gfx-rs#414 Approach mostly mimicked from [gfx-portability](https://github.com/gfx-rs/portability) as recommended to me by @kvark. I needed a number of commits to iron out some kinks for the Windows builds, so I would recommend using squash merge when accepting this PR. Note that the Windows rust=nightly build fails, but it's also broken on master, so it's unrelated to the changes in this PR. /cc @almarklein # Questions - [x] Would it make sense to also regenerate the `ffi/wgpu.h` and `wgpu-remote.h` header files and include them in the zip archive? # Todo for maintainers - [x] Configure encrypted `api_key` As in [gfx-portability](https://github.com/gfx-rs/portability/blob/master/.travis.yml#L61) you will need to create an API key and commit it to the `.travis.yml` file. I've checked "allow edits from maintainers" so you should be able to commit to this branch directly. You may want to reference the [Travis instructions](https://docs.travis-ci.com/user/deployment/releases/#authenticating-with-an-oauth-token) as well. - [ ] Tag revisions Previous versions (`v0.1` - `v0.4`) have not been tagged on the master branch, you will want to do so retroactively. Also, when releasing in the future, make sure to tag the commit before pushing. Alternatively, you can schedule a travis build manually after applying the tag retroactively. 420: Make Origin3d::{x,y,z} all have type u32 r=kvark a=fintelia Fixes gfx-rs#419 424: swapchain creation: check if selected present mode is supported r=kvark a=Veykril Implements a simple check as talked about in gfx-rs#350 to fallback to `FIFO` should the selected present mode not be available on the system. Co-authored-by: Korijn van Golen <k.vangolen@clinicalgraphics.com> Co-authored-by: Korijn van Golen <korijn@gmail.com> Co-authored-by: Jonathan Behrens <fintelia@gmail.com> Co-authored-by: Veykril <lukastw97@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.