Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Graphics to submit draw calls as they come. #299

Closed
kvark opened this issue Aug 28, 2014 · 2 comments
Closed

Switch Graphics to submit draw calls as they come. #299

kvark opened this issue Aug 28, 2014 · 2 comments
Labels
difficulty: average type: bug value: medium

Comments

@kvark
Copy link
Member

kvark commented Aug 28, 2014

There is no need to wait for the end of the frame.
cc @bvssvni
emberian added a commit to emberian/gfx-rs that referenced this issue Nov 7, 2014
@emberian
Make Graphics submit all calls instantly
ef01a12 
There is no reason to wait, we are on the same thread as the device.

Closes gfx-rs#299
@emberian emberian reopened this Nov 9, 2014
@emberian
Copy link
Contributor

emberian commented Nov 9, 2014

The change has been reverted, since it broke the state cache

@msiglreith
Copy link
Contributor

Closing this as it seems outdated. We moved towards a CommandBuffer + CommandQueue approach.

adamnemecek pushed a commit to adamnemecek/gfx that referenced this issue Apr 1, 2021
@bors @yanchith
Merge gfx-rs#299
150d226 
299: Rename buffer to encoder in wgpu_command_buffer_copy_* functions r=kvark a=yanchith

This also regenerates `wgpu.h` and updates uses of `wgpu_command_buffer_copy_buffer_to_buffer` in `compute/main.c`.

EDIT: all good...
~Note that I couldn't regenerate `wgpu-remote.h` because of the following cbindgen error:~

```
ERROR: Cannot find a mangling for generic path GenericPath { path: Path { name: "Adapter" }, export_name: "Adapter", generics: [Path(GenericPath { path: Path { name: "Backend" }, export_name: "Backend", generics: [], ctype: None })], ctype: None }. This usually means that a type referenced by this generic was incompatible or not found.
```

Should we investigate before merging? Maybe I am just using an unlucky nightly?

Closes: gfx-rs#250 

Co-authored-by: yanchith <yanchi.toth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: average type: bug value: medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kvark @emberian @msiglreith