Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: style fixes staging #986

Merged
merged 3 commits into from
Jun 20, 2023
Merged

fix: style fixes staging #986

merged 3 commits into from
Jun 20, 2023

Conversation

jfrader
Copy link
Contributor

@jfrader jfrader commented Jun 20, 2023

Resolves GEY-2668
Resolves GEY-2565
Resolves GEY-1899
Resolves GEY-2506

@linear
Copy link

linear bot commented Jun 20, 2023

GEY-2506 When project page loads the status is DRAFT by default

Screenshot_2023-06-04-20-21-30-28_40deb401b9ffe8e1df2f1cc5ba480b12.jpg

Issue

Notice that the project says DRAFT. When you first load the page it says draft then it changed to RUNNING. this feels a bit glitchy.

Solution.

Let's have a skeleton component as the default when the project status is loading (rather than DRAFT)

GEY-2668 Change padding between components to 10px

fran , apologies for the back and fourth on this, but think we can change this to 10px padding between components in the main project section.

Screen Shot 2023-06-18 at 15.24.40.png

GEY-2565 Show transparent background image differently

Issue:

  • remove the border around the project image
  • apply a shadow on the image.
    • if the image is transparent, the shadow get's applied on the border of the image around the transparency. (Pepsi logo
    • if the image is not transparent, the shadow get's applied on the border of the entire file (see Paco image)

Shadow:

Screen Shot 2023-06-08 at 09.28.11.png

Screen Shot 2023-06-08 at 09.27.48.png

Screen Shot 2023-06-08 at 09.22.57.png

GEY-1899 Frontend showcasing videos as headers

  • Pickup youtube

Note:

  • Update max height of the project header image to 350px

Frame 10420 - Geyser product designs (Figma)

@jfrader jfrader merged commit 53a989d into staging Jun 20, 2023
@jfrader jfrader deleted the fran/staging-fixes-jun-20 branch June 20, 2023 18:14
sajald77 added a commit that referenced this pull request Jun 20, 2023
* staging:
  fix: style fixes staging (#986)
  feat: make rewards selectable only (#987)
  fix: staging fixes + delete unused components
  fix: project layout cleanup
jfrader added a commit that referenced this pull request Jun 20, 2023
* fix: style fixes staging

* chore: remove unused import

* chore: remove unwanted layer
jfrader added a commit that referenced this pull request Jun 20, 2023
* fix: style fixes staging

* chore: remove unused import

* chore: remove unwanted layer
jfrader added a commit that referenced this pull request Jun 20, 2023
* fix: style fixes staging

* chore: remove unused import

* chore: remove unwanted layer
jfrader added a commit that referenced this pull request Jun 20, 2023
* fix: style fixes staging

* chore: remove unused import

* chore: remove unwanted layer
sajald77 added a commit that referenced this pull request Jun 21, 2023
…91-fran/rebase-main-to-staging

* staging: (76 commits)
  fix: have nextStage call inside invoiceID match condition
  fix: responsive project headers
  fix: update project header text variants
  fix: header title fix
  v0.2.0
  chore: fix types
  chore: update types
  fix: style fixes staging (#986)
  feat: make rewards selectable only (#987)
  chore: cleanup
  fix: staging fixes + delete unused components
  fix: project layout cleanup
  fix: validate entry.id before publishing
  chore: minor cleanup
  fix: go back in history when back in entry
  fix: retry the graphql operation if the error is expired_refresh_token
  chore: cleanup
  feat: video as header (#969)
  fix: remove draft status before status loaded (#970)
  feat: create button below the left sidebar (#966)
  ...

# Conflicts:
#	src/hooks/fundingFlow/useFundingFlow.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants