Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove draft status before status loaded #970

Conversation

jfrader
Copy link
Contributor

@jfrader jfrader commented Jun 15, 2023

No description provided.

@linear
Copy link

linear bot commented Jun 15, 2023

GEY-2506 When project page loads the status is DRAFT by default

Screenshot_2023-06-04-20-21-30-28_40deb401b9ffe8e1df2f1cc5ba480b12.jpg

Issue

Notice that the project says DRAFT. When you first load the page it says draft then it changed to RUNNING. this feels a bit glitchy.

Solution.

Let's have a skeleton component as the default when the project status is loading (rather than DRAFT)

@jfrader jfrader merged commit b328ce6 into staging Jun 16, 2023
@jfrader jfrader deleted the fran/gey-2506-when-project-page-loads-the-status-is-draft-by-default branch June 16, 2023 03:18
jfrader added a commit that referenced this pull request Jun 20, 2023
* fix: remove draft status before status loaded

* refactor: improve code
jfrader added a commit that referenced this pull request Jun 20, 2023
* fix: remove draft status before status loaded

* refactor: improve code
jfrader added a commit that referenced this pull request Jun 20, 2023
* fix: remove draft status before status loaded

* refactor: improve code
jfrader added a commit that referenced this pull request Jun 20, 2023
* fix: remove draft status before status loaded

* refactor: improve code
sajald77 added a commit that referenced this pull request Jun 21, 2023
…91-fran/rebase-main-to-staging

* staging: (76 commits)
  fix: have nextStage call inside invoiceID match condition
  fix: responsive project headers
  fix: update project header text variants
  fix: header title fix
  v0.2.0
  chore: fix types
  chore: update types
  fix: style fixes staging (#986)
  feat: make rewards selectable only (#987)
  chore: cleanup
  fix: staging fixes + delete unused components
  fix: project layout cleanup
  fix: validate entry.id before publishing
  chore: minor cleanup
  fix: go back in history when back in entry
  fix: retry the graphql operation if the error is expired_refresh_token
  chore: cleanup
  feat: video as header (#969)
  fix: remove draft status before status loaded (#970)
  feat: create button below the left sidebar (#966)
  ...

# Conflicts:
#	src/hooks/fundingFlow/useFundingFlow.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants