fix(ui): Adds locked project id to the URL on issue details page if it does not exist. #14731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iProgramStuff
changed the title
markstory
reviewed
Sep 16, 2019
src/sentry/static/sentry/app/views/organizationGroupDetails/groupDetails.jsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/views/organizationGroupDetails/groupDetails.jsx
Outdated
Show resolved
Hide resolved
billyvg
reviewed
Sep 16, 2019
src/sentry/static/sentry/app/views/organizationGroupDetails/groupDetails.jsx
Outdated
Show resolved
Hide resolved
billyvg
reviewed
Sep 16, 2019
src/sentry/static/sentry/app/views/organizationGroupDetails/groupDetails.jsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/views/organizationGroupDetails/groupDetails.jsx
Outdated
Show resolved
Hide resolved
iProgramStuff
force-pushed
the
fix/SEN-1024
branch
from
39e344c
to
bafefb5
Compare
markstory
reviewed
Sep 24, 2019
src/sentry/static/sentry/app/components/organizations/globalSelectionHeader/index.jsx
Outdated
Show resolved
Hide resolved
billyvg
reviewed
Sep 24, 2019
src/sentry/static/sentry/app/views/organizationGroupDetails/groupDetails.jsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/views/organizationGroupDetails/groupDetails.jsx
Show resolved
Hide resolved
billyvg
approved these changes
Sep 30, 2019
src/sentry/static/sentry/app/views/organizationGroupDetails/groupDetails.jsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/views/organizationGroupDetails/groupDetails.jsx
Outdated
Show resolved
Hide resolved
iProgramStuff
force-pushed
the
fix/SEN-1024
branch
from
35f1c71
to
7b91c0a
Compare
billyvg
added a commit
that referenced
this pull request
Apr 22, 2020
This basically re-implements #13689 in a more simple way. This is possible due to other changes that we have done to issue details (#13875, #14731). This also (semi) fixes an issue with loading Issue Details with an environment in the URL. Previously, it would fetch details API serially: 1) without env and 2) with env. There would be a slight flicker between loading -> finished req #1 -> loading -> finished req #2. Now this seems to fire both at near the same time and cancels the initial request almost immediately. This is still not ideal but is an interim-fix as the ideal solution is a bit more involved, but will be on its way.
billyvg
added a commit
that referenced
this pull request
Apr 23, 2020
This basically re-implements #13689 in a more simple way. This is possible due to other changes that we have done to issue details (#13875, #14731). This also (semi) fixes an issue with loading Issue Details with an environment in the URL. Previously, it would fetch details API serially: 1) without env and 2) with env. There would be a slight flicker between loading -> finished req #1 -> loading -> finished req #2. Now this seems to fire both at near the same time and cancels the initial request almost immediately. This is still not ideal but is an interim-fix as the ideal solution is a bit more involved, but will be on its way.
billyvg
added a commit
that referenced
this pull request
Apr 26, 2020
This basically re-implements #13689 in a more simple way. This is possible due to other changes that we have done to issue details (#13875, #14731). This also (semi) fixes an issue with loading Issue Details with an environment in the URL. Previously, it would fetch details API serially: 1) without env and 2) with env. There would be a slight flicker between loading -> finished req #1 -> loading -> finished req #2. Now this seems to fire both at near the same time and cancels the initial request almost immediately. This is still not ideal but is an interim-fix as the ideal solution is a bit more involved, but will be on its way.
billyvg
added a commit
that referenced
this pull request
Apr 27, 2020
This basically re-implements #13689 in a more simple way. This is possible due to other changes that we have done to issue details (#13875, #14731). This also (semi) fixes an issue with loading Issue Details with an environment in the URL. Previously, it would fetch details API serially: 1) without env and 2) with env. There would be a slight flicker between loading -> finished req #1 -> loading -> finished req #2. Now this seems to fire both at near the same time and cancels the initial request almost immediately. This is still not ideal but is an interim-fix as the ideal solution is a bit more involved, but will be on its way. The tests introduced in #18452 should cover the changes in this PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the project parameter to the URL (based on the project we autoselect and lock a user to) when browsing to an issue that does not have it.
Drawback: When browsing to an issue from the issue list page, with no project filter (i.e. all projects 'selectedl'), the filter gets added and going back can feel like a poor user experience. Will look into solving this later - Billy recommended pushing this fix in the meantime, though.
Fixes SEN-1024