small fixes to get example_project working #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wanted to mention that we plan to tweak the requirements so it doesnt need to be postgres. We can do a similar sort in most DB engines, but its engine specific, and we can fall back to just sorting by last seen, or times seen. |
|
That is a good approach to make it engine agnostic, but having undocumented dependencies like postgres (for the moment) and pygooglechart is a bad practice; at least document them. |
plocharz-9livesdata
pushed a commit
to plocharz-9livesdata/sentry
that referenced
this pull request
May 18, 2018
plocharz-9livesdata
pushed a commit
to plocharz-9livesdata/sentry
that referenced
this pull request
Oct 26, 2018
billyvg
added a commit
that referenced
this pull request
Apr 22, 2020
This basically re-implements #13689 in a more simple way. This is possible due to other changes that we have done to issue details (#13875, #14731). This also (semi) fixes an issue with loading Issue Details with an environment in the URL. Previously, it would fetch details API serially: 1) without env and 2) with env. There would be a slight flicker between loading -> finished req #1 -> loading -> finished req #2. Now this seems to fire both at near the same time and cancels the initial request almost immediately. This is still not ideal but is an interim-fix as the ideal solution is a bit more involved, but will be on its way.
billyvg
added a commit
that referenced
this pull request
Apr 23, 2020
This basically re-implements #13689 in a more simple way. This is possible due to other changes that we have done to issue details (#13875, #14731). This also (semi) fixes an issue with loading Issue Details with an environment in the URL. Previously, it would fetch details API serially: 1) without env and 2) with env. There would be a slight flicker between loading -> finished req #1 -> loading -> finished req #2. Now this seems to fire both at near the same time and cancels the initial request almost immediately. This is still not ideal but is an interim-fix as the ideal solution is a bit more involved, but will be on its way.
billyvg
added a commit
that referenced
this pull request
Apr 26, 2020
This basically re-implements #13689 in a more simple way. This is possible due to other changes that we have done to issue details (#13875, #14731). This also (semi) fixes an issue with loading Issue Details with an environment in the URL. Previously, it would fetch details API serially: 1) without env and 2) with env. There would be a slight flicker between loading -> finished req #1 -> loading -> finished req #2. Now this seems to fire both at near the same time and cancels the initial request almost immediately. This is still not ideal but is an interim-fix as the ideal solution is a bit more involved, but will be on its way.
billyvg
added a commit
that referenced
this pull request
Apr 27, 2020
This basically re-implements #13689 in a more simple way. This is possible due to other changes that we have done to issue details (#13875, #14731). This also (semi) fixes an issue with loading Issue Details with an environment in the URL. Previously, it would fetch details API serially: 1) without env and 2) with env. There would be a slight flicker between loading -> finished req #1 -> loading -> finished req #2. Now this seems to fire both at near the same time and cancels the initial request almost immediately. This is still not ideal but is an interim-fix as the ideal solution is a bit more involved, but will be on its way. The tests introduced in #18452 should cover the changes in this PR.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off I noticed the pygooglechart dependency which was not documented so I added some view code which only uses it if the package is installed, otherwise the views will not fail. I also patched up the README to include the dependencies which are postgresql, Django>=1.2 (for external db logging), and pygooglechart (which i made optional). Also when trying to test the example project i saw that the app itself was not added to the path, which i corrected to point to the app in the current checkout. I also saw a 'paging' app and i have no idea where that is coming from. Where can I get 'paging' and what does it do? Im trying to get this into a good shape enough so that i can clone the repo, cd to example_project, and get the project up and running so I can see the error reporting. The postgres only approach is the hardest thing to overcome in my opinion, but I can see that it is necessary to do some high performance analytics on the errors.