Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter beforeSendTransaction from the Native SDK #3140

Merged
merged 8 commits into from
Jul 7, 2023
Merged

Filter beforeSendTransaction from the Native SDK #3140

merged 8 commits into from
Jul 7, 2023

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Jun 22, 2023 •
edited
Loading

Includes beforeSendTransaction to the list of filtered items from the Native SDK.
Close #3069

TODO: tests for beforeSendTransaction and also the other cases that were ignored.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2023 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 281.49 ms 338.98 ms 57.49 ms
Size 7.15 MiB 8.08 MiB 955.77 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
e2b64fe+dirty 258.82 ms 304.26 ms 45.44 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
0db0c72+dirty 335.20 ms 351.06 ms 15.86 ms
b1e8712+dirty 322.55 ms 331.84 ms 9.29 ms
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
52a8031+dirty 330.72 ms 358.76 ms 28.03 ms

App size

Revision Plain With Sentry Diff
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
e2b64fe+dirty 7.15 MiB 8.07 MiB 947.16 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
0db0c72+dirty 7.15 MiB 8.04 MiB 911.02 KiB
b1e8712+dirty 7.15 MiB 8.04 MiB 912.27 KiB
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
52a8031+dirty 7.15 MiB 8.09 MiB 965.95 KiB

@lucas-zimerman lucas-zimerman changed the title Add filter for beforeSendTransaction Filter beforeSendTransaction from the Native SDK Jun 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2023 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 330.35 ms 364.02 ms 33.67 ms
Size 17.73 MiB 19.81 MiB 2.08 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
70caa60+dirty 299.00 ms 321.02 ms 22.02 ms
e2b64fe 316.88 ms 330.23 ms 13.35 ms
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
ad6c299 375.94 ms 382.02 ms 6.08 ms
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
80b2ce3 385.02 ms 387.36 ms 2.34 ms
34aba08 328.10 ms 342.84 ms 14.74 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms

App size

Revision Plain With Sentry Diff
70caa60+dirty 17.73 MiB 19.75 MiB 2.01 MiB
e2b64fe 17.73 MiB 19.80 MiB 2.07 MiB
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
ad6c299 17.73 MiB 19.75 MiB 2.02 MiB
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
80b2ce3 17.73 MiB 19.75 MiB 2.02 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2023 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1265.20 ms 1267.20 ms 2.00 ms
Size 2.92 MiB 3.41 MiB 503.54 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
70caa60+dirty 1279.08 ms 1281.54 ms 2.46 ms
9a3ca65+dirty 1276.40 ms 1279.14 ms 2.74 ms
e2b64fe+dirty 1285.78 ms 1297.56 ms 11.78 ms
d197b5c+dirty 1234.80 ms 1249.20 ms 14.40 ms
15c80ab+dirty 1248.41 ms 1251.24 ms 2.83 ms
0db0c72+dirty 1258.88 ms 1262.52 ms 3.64 ms
b1e8712+dirty 1284.11 ms 1297.82 ms 13.71 ms
8900e1a+dirty 1268.36 ms 1273.04 ms 4.68 ms
76d1baf+dirty 1245.00 ms 1257.76 ms 12.76 ms
52a8031+dirty 1255.96 ms 1273.00 ms 17.04 ms

App size

Revision Plain With Sentry Diff
70caa60+dirty 2.92 MiB 3.39 MiB 486.04 KiB
9a3ca65+dirty 2.92 MiB 3.37 MiB 464.32 KiB
e2b64fe+dirty 2.92 MiB 3.41 MiB 499.97 KiB
d197b5c+dirty 2.92 MiB 3.37 MiB 464.41 KiB
15c80ab+dirty 2.92 MiB 3.39 MiB 481.56 KiB
0db0c72+dirty 2.92 MiB 3.40 MiB 492.71 KiB
b1e8712+dirty 2.92 MiB 3.40 MiB 494.15 KiB
8900e1a+dirty 2.92 MiB 3.39 MiB 485.96 KiB
76d1baf+dirty 2.92 MiB 3.38 MiB 475.74 KiB
52a8031+dirty 2.92 MiB 3.38 MiB 475.71 KiB

@lucas-zimerman lucas-zimerman marked this pull request as ready for review July 6, 2023 10:44
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1257.61 ms 1272.19 ms 14.58 ms
Size 2.36 MiB 2.85 MiB 499.82 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
e2b64fe+dirty 1232.22 ms 1255.20 ms 22.98 ms
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms
15c80ab+dirty 1223.74 ms 1228.96 ms 5.22 ms
0db0c72+dirty 1275.02 ms 1285.84 ms 10.82 ms
b1e8712+dirty 1256.02 ms 1265.14 ms 9.12 ms
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
52a8031+dirty 1280.88 ms 1289.78 ms 8.90 ms

App size

Revision Plain With Sentry Diff
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
e2b64fe+dirty 2.36 MiB 2.85 MiB 495.80 KiB
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB
15c80ab+dirty 2.36 MiB 2.83 MiB 474.49 KiB
0db0c72+dirty 2.36 MiB 2.84 MiB 487.01 KiB
b1e8712+dirty 2.36 MiB 2.84 MiB 488.84 KiB
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
52a8031+dirty 2.36 MiB 2.82 MiB 469.44 KiB

krystofwoldrich
krystofwoldrich approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good. 🚀

@lucas-zimerman lucas-zimerman merged commit 4acc111 into main Jul 7, 2023
@lucas-zimerman lucas-zimerman deleted the fix/filtert-beforeSendTransaction branch July 7, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

@marandaneto marandaneto Awaiting requested review from marandaneto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing filter for beforeSendTransaction on Native Layer
2 participants
@lucas-zimerman @krystofwoldrich