Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing filter for beforeSendTransaction on Native Layer #3069

Closed
lucas-zimerman opened this issue May 15, 2023 · 1 comment · Fixed by #3140
Closed

Missing filter for beforeSendTransaction on Native Layer #3069

lucas-zimerman opened this issue May 15, 2023 · 1 comment · Fixed by #3140
Assignees
Milestone

Comments

@lucas-zimerman
Copy link
Collaborator

lucas-zimerman commented May 15, 2023

    const { beforeSend, beforeBreadcrumb, integrations, ...filteredOptions } = options;
    /* eslint-enable @typescript-eslint/unbound-method,@typescript-eslint/no-unused-vars */
    const nativeIsReady = await RNSentry.initNativeSdk(filteredOptions);

The current filter on the wrapper only applies for beforeSend but doesn't filter the beforeSendTransaction. We should filter in order to avoid issues with the Native SDK on iOS

Proposed Solution

a function that receives the React Native options, and return a new object that only contains the valid objects, this avoids users adding custom parameters to the options and the same being sent to the Native Layer, but also prevents that new parameters doesn't get added automatically to the Native layer.

@krystofwoldrich
Copy link
Member

iOS doesn't have the beforeSendTransaction so this is not causing issues at the moment, but could in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants