Disable enableNative if Native SDK was not initialized #3099

lucas-zimerman · 2023-06-04T16:49:36Z

sets the flag EnableNative if makeNativeTransportFactory failed to be created.

Platform.OS could be 'Android' on Expo so we can not rely on that value in order to set EnableNative to true/false

Validated issues:
https://sentry-sdks.sentry.io/issues/4227272790/events/e80ef7a5799c43c69e9d69c53df24b16/?project=5428561

https://sentry-sdks.sentry.io/issues/4227268747/events/47a07470db4641ea90e5c7f124e0c623/?project=5428561

https://sentry-sdks.sentry.io/issues/4227271973/events/d94ead040c684d459b172e1458c8504e/?project=5428561

Close #3027

github-actions · 2023-06-04T16:50:33Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 7c491a6

github-actions · 2023-06-04T17:16:00Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	348.66 ms	353.22 ms	4.56 ms
Size	17.73 MiB	19.80 MiB	2.07 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`86d6d2c`+dirty	332.90 ms	352.45 ms	19.55 ms
`ad6c299`	375.94 ms	382.02 ms	6.08 ms
`e73f4ed`+dirty	332.96 ms	354.33 ms	21.37 ms
`8900e1a`+dirty	430.68 ms	456.13 ms	25.44 ms
`d0bf494`+dirty	375.37 ms	395.14 ms	19.77 ms
`76d1baf`+dirty	335.72 ms	355.52 ms	19.80 ms
`34aba08`	328.10 ms	342.84 ms	14.74 ms
`80b2ce3`	385.02 ms	387.36 ms	2.34 ms
`b1e8712`	462.11 ms	465.71 ms	3.60 ms
`dadc233`+dirty	333.78 ms	343.94 ms	10.16 ms

App size

Revision	Plain	With Sentry	Diff
`86d6d2c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`ad6c299`	17.73 MiB	19.75 MiB	2.02 MiB
`e73f4ed`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`8900e1a`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`d0bf494`+dirty	17.73 MiB	19.75 MiB	2.02 MiB
`76d1baf`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`34aba08`	17.73 MiB	19.80 MiB	2.07 MiB
`80b2ce3`	17.73 MiB	19.75 MiB	2.02 MiB
`b1e8712`	17.73 MiB	19.75 MiB	2.02 MiB
`dadc233`+dirty	17.73 MiB	19.75 MiB	2.02 MiB

Previous results on branch: feat/non-native-env

Startup times

Revision	Plain	With Sentry	Diff
`87e0e46`	307.96 ms	316.71 ms	8.76 ms

App size

Revision	Plain	With Sentry	Diff
`87e0e46`	17.73 MiB	19.80 MiB	2.07 MiB

github-actions · 2023-06-04T17:29:15Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1224.00 ms	1233.74 ms	9.74 ms
Size	2.36 MiB	2.85 MiB	495.72 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`b1e8712`+dirty	1256.02 ms	1265.14 ms	9.12 ms
`86d6d2c`+dirty	1267.55 ms	1286.21 ms	18.66 ms
`e73f4ed`+dirty	1243.27 ms	1244.52 ms	1.25 ms
`8900e1a`+dirty	1210.27 ms	1218.66 ms	8.39 ms
`d0bf494`+dirty	1289.40 ms	1298.40 ms	9.00 ms
`0db0c72`+dirty	1275.02 ms	1285.84 ms	10.82 ms
`76d1baf`+dirty	1244.10 ms	1268.52 ms	24.42 ms
`34aba08`+dirty	1276.78 ms	1308.52 ms	31.74 ms
`ad6c299`+dirty	1244.76 ms	1260.10 ms	15.34 ms
`dadc233`+dirty	1223.20 ms	1236.88 ms	13.68 ms

App size

Revision	Plain	With Sentry	Diff
`b1e8712`+dirty	2.36 MiB	2.84 MiB	488.84 KiB
`86d6d2c`+dirty	2.36 MiB	2.82 MiB	462.82 KiB
`e73f4ed`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`8900e1a`+dirty	2.36 MiB	2.83 MiB	479.25 KiB
`d0bf494`+dirty	2.36 MiB	2.83 MiB	481.15 KiB
`0db0c72`+dirty	2.36 MiB	2.84 MiB	487.01 KiB
`76d1baf`+dirty	2.36 MiB	2.82 MiB	469.45 KiB
`34aba08`+dirty	2.36 MiB	2.85 MiB	495.32 KiB
`ad6c299`+dirty	2.36 MiB	2.84 MiB	488.85 KiB
`dadc233`+dirty	2.36 MiB	2.84 MiB	486.85 KiB

Previous results on branch: feat/non-native-env

Startup times

Revision	Plain	With Sentry	Diff
`87e0e46`+dirty	1271.76 ms	1281.46 ms	9.70 ms

App size

Revision	Plain	With Sentry	Diff
`87e0e46`+dirty	2.36 MiB	2.85 MiB	495.50 KiB

github-actions · 2023-06-04T17:37:12Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1245.98 ms	1261.18 ms	15.20 ms
Size	2.92 MiB	3.41 MiB	499.85 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`b1e8712`+dirty	1284.11 ms	1297.82 ms	13.71 ms
`86d6d2c`+dirty	1291.62 ms	1296.80 ms	5.18 ms
`e73f4ed`+dirty	1282.90 ms	1309.30 ms	26.40 ms
`8900e1a`+dirty	1268.36 ms	1273.04 ms	4.68 ms
`d0bf494`+dirty	1266.20 ms	1267.52 ms	1.32 ms
`0db0c72`+dirty	1258.88 ms	1262.52 ms	3.64 ms
`76d1baf`+dirty	1245.00 ms	1257.76 ms	12.76 ms
`34aba08`+dirty	1268.58 ms	1276.80 ms	8.22 ms
`ad6c299`+dirty	1248.50 ms	1248.88 ms	0.38 ms
`dadc233`+dirty	1266.52 ms	1282.55 ms	16.03 ms

App size

Revision	Plain	With Sentry	Diff
`b1e8712`+dirty	2.92 MiB	3.40 MiB	494.15 KiB
`86d6d2c`+dirty	2.92 MiB	3.37 MiB	464.31 KiB
`e73f4ed`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`8900e1a`+dirty	2.92 MiB	3.39 MiB	485.96 KiB
`d0bf494`+dirty	2.92 MiB	3.40 MiB	488.08 KiB
`0db0c72`+dirty	2.92 MiB	3.40 MiB	492.71 KiB
`76d1baf`+dirty	2.92 MiB	3.38 MiB	475.74 KiB
`34aba08`+dirty	2.92 MiB	3.41 MiB	499.03 KiB
`ad6c299`+dirty	2.92 MiB	3.40 MiB	494.12 KiB
`dadc233`+dirty	2.92 MiB	3.40 MiB	492.53 KiB

Previous results on branch: feat/non-native-env

Startup times

Revision	Plain	With Sentry	Diff
`87e0e46`+dirty	1250.57 ms	1271.91 ms	21.34 ms

App size

Revision	Plain	With Sentry	Diff
`87e0e46`+dirty	2.92 MiB	3.41 MiB	499.64 KiB

github-actions · 2023-06-04T17:51:58Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	282.65 ms	331.61 ms	48.96 ms
Size	7.15 MiB	8.07 MiB	946.51 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`b1e8712`+dirty	322.55 ms	331.84 ms	9.29 ms
`86d6d2c`+dirty	267.21 ms	325.24 ms	58.04 ms
`e73f4ed`+dirty	262.98 ms	311.02 ms	48.04 ms
`8900e1a`+dirty	371.40 ms	377.70 ms	6.31 ms
`d0bf494`+dirty	253.73 ms	308.23 ms	54.49 ms
`0db0c72`+dirty	335.20 ms	351.06 ms	15.86 ms
`76d1baf`+dirty	339.02 ms	408.65 ms	69.63 ms
`34aba08`+dirty	331.79 ms	376.69 ms	44.91 ms
`ad6c299`+dirty	336.47 ms	362.89 ms	26.42 ms
`dadc233`+dirty	363.19 ms	370.37 ms	7.18 ms

App size

Revision	Plain	With Sentry	Diff
`b1e8712`+dirty	7.15 MiB	8.04 MiB	912.27 KiB
`86d6d2c`+dirty	7.15 MiB	8.09 MiB	962.69 KiB
`e73f4ed`+dirty	7.15 MiB	8.09 MiB	965.94 KiB
`8900e1a`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`d0bf494`+dirty	7.15 MiB	8.04 MiB	910.85 KiB
`0db0c72`+dirty	7.15 MiB	8.04 MiB	911.02 KiB
`76d1baf`+dirty	7.15 MiB	8.09 MiB	964.41 KiB
`34aba08`+dirty	7.15 MiB	8.07 MiB	946.13 KiB
`ad6c299`+dirty	7.15 MiB	8.04 MiB	912.17 KiB
`dadc233`+dirty	7.15 MiB	8.04 MiB	910.84 KiB

Previous results on branch: feat/non-native-env

Startup times

Revision	Plain	With Sentry	Diff
`87e0e46`+dirty	279.30 ms	331.46 ms	52.16 ms

App size

Revision	Plain	With Sentry	Diff
`87e0e46`+dirty	7.15 MiB	8.07 MiB	946.51 KiB

marandaneto · 2023-06-05T10:06:40Z

Is this somehow a dupe of #3093 ?

lucas-zimerman · 2023-06-05T13:37:25Z

Is this somehow a dupe of #3093 ?

Seems to be a different case.
on the wrapper, this.enableNative has a fixed flow, it starts as true by default, and it changes to false when closing the SDK. But once reinitialised, this flow isn't reset so true will stay with the previous value set that was false.

PR #3093 fixes this flow where this PR fixes the initial value of enableNative to false if the NativeTransport isn't available.

src/js/sdk.tsx

krystofwoldrich · 2023-06-06T10:52:16Z

Let's add one or two tests into sdk.test.ts. Something to ensure that we are disabling native and maybe one for the case when people supply their own transport but native is not available.

    it('falls back to fetch if native flag enabled but native not available', () => {
      (NATIVE.isNativeAvailable as jest.Mock).mockImplementation(() => false);
      init({ enableNative: true });
      expect(usedOptions()?.enableNative).toEqual(false);
      expect(NATIVE.isNativeAvailable).toBeCalled();
    });

Besides that, it looks good, thanks for the events examples.

PS.: I've noticed none of the stack traces is symbolicated, but I see symbolicate calls in the breadcrumbs, strange.

lucas-zimerman · 2023-06-07T15:39:13Z

issue in regard to the stack trace was created here: #3104

CHANGELOG.md

src/js/sdk.tsx

Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com>

test/sdk.test.ts

krystofwoldrich

Looks good. Thank you! 🚀🚀

disable enableNative if native SDK did not initialize

c597970

lucas-zimerman added 2 commits June 5, 2023 01:51

update changelog

65bf2cc

nit changelog

9875076

lucas-zimerman marked this pull request as ready for review June 4, 2023 17:02

lucas-zimerman requested review from marandaneto and krystofwoldrich as code owners June 4, 2023 17:02

fix test

d139df9

krystofwoldrich reviewed Jun 6, 2023

View reviewed changes

src/js/sdk.tsx Outdated Show resolved Hide resolved

krystofwoldrich reviewed Jun 6, 2023

View reviewed changes

src/js/sdk.tsx Outdated Show resolved Hide resolved

lucas-zimerman added 3 commits June 7, 2023 23:43

add tests and small refactor based on request change

f35b480

nits yarn

88753eb

fix prettier (vscode ignoring it)

3eaedb6

krystofwoldrich reviewed Jun 12, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

krystofwoldrich reviewed Jun 12, 2023

View reviewed changes

src/js/sdk.tsx Outdated Show resolved Hide resolved

krystofwoldrich reviewed Jun 12, 2023

View reviewed changes

src/js/sdk.tsx Outdated Show resolved Hide resolved

lucas-zimerman and others added 3 commits June 13, 2023 19:49

Apply suggestions from code review

ca5b591

Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com>

additional tests for passed enableNative

5c7252b

Merge branch 'main' into feat/non-native-env

0b247bd

lucas-zimerman commented Jun 13, 2023

View reviewed changes

test/sdk.test.ts Outdated Show resolved Hide resolved

test/sdk.test.ts Outdated Show resolved Hide resolved

test/sdk.test.ts Outdated Show resolved Hide resolved

Fix vscode spacing.

7c491a6

lucas-zimerman requested a review from krystofwoldrich June 13, 2023 11:03

krystofwoldrich approved these changes Jun 13, 2023

View reviewed changes

krystofwoldrich merged commit c4d59b2 into main Jun 13, 2023

krystofwoldrich deleted the feat/non-native-env branch June 13, 2023 13:45

lucas-zimerman mentioned this pull request Jun 27, 2023

Fallback to JavaScript SDK if Native failed to initialize getsentry/sentry-capacitor#171

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable enableNative if Native SDK was not initialized #3099

Disable enableNative if Native SDK was not initialized #3099

lucas-zimerman commented Jun 4, 2023 •

edited

Loading

github-actions bot commented Jun 4, 2023 •

edited

Loading

github-actions bot commented Jun 4, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/non-native-env

Startup times

App size

github-actions bot commented Jun 4, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/non-native-env

Startup times

App size

github-actions bot commented Jun 4, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/non-native-env

Startup times

App size

github-actions bot commented Jun 4, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/non-native-env

Startup times

App size

marandaneto commented Jun 5, 2023

lucas-zimerman commented Jun 5, 2023

krystofwoldrich commented Jun 6, 2023

lucas-zimerman commented Jun 7, 2023

krystofwoldrich left a comment

Disable enableNative if Native SDK was not initialized #3099

Disable enableNative if Native SDK was not initialized #3099

Conversation

lucas-zimerman commented Jun 4, 2023 • edited Loading

github-actions bot commented Jun 4, 2023 • edited Loading

github-actions bot commented Jun 4, 2023 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/non-native-env

Startup times

App size

github-actions bot commented Jun 4, 2023 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/non-native-env

Startup times

App size

github-actions bot commented Jun 4, 2023 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/non-native-env

Startup times

App size

github-actions bot commented Jun 4, 2023 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/non-native-env

Startup times

App size

marandaneto commented Jun 5, 2023

lucas-zimerman commented Jun 5, 2023

krystofwoldrich commented Jun 6, 2023

lucas-zimerman commented Jun 7, 2023

krystofwoldrich left a comment

Choose a reason for hiding this comment

lucas-zimerman commented Jun 4, 2023 •

edited

Loading

github-actions bot commented Jun 4, 2023 •

edited

Loading

github-actions bot commented Jun 4, 2023 •

edited

Loading

github-actions bot commented Jun 4, 2023 •

edited

Loading

github-actions bot commented Jun 4, 2023 •

edited

Loading

github-actions bot commented Jun 4, 2023 •

edited

Loading