Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK with enableNative: true falls back to JS if native is not available #3027

Closed
Tracked by #3102
krystofwoldrich opened this issue May 2, 2023 · 2 comments · Fixed by #3099
Closed
Tracked by #3102

SDK with enableNative: true falls back to JS if native is not available #3027

krystofwoldrich opened this issue May 2, 2023 · 2 comments · Fixed by #3099
Assignees
Milestone

Comments

@krystofwoldrich
Copy link
Member

krystofwoldrich commented May 2, 2023

Description

At the moment RN SDK throws an error when enableNative: true with Expo Go, to make DEX better we should not enforceNative but only warn about the situation and use JS as a fallback.

This is especially an improvement for Expo users and react-native-web users.

We add forceNative flag to keep the original behavior for users who want it.

@marandaneto
Copy link
Contributor

marandaneto commented May 12, 2023

Let's just flip (and log out) enableNative if it's not Android, iOS, and macOS, where the Native SDKs are not available anyway.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants