-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Deduplicate yarn.lock #14968
Conversation
@mydea I'm unable to reproduce the integration test failures (https://github.com/getsentry/sentry-javascript/actions/runs/12751414906/job/35538905465?pr=14968) locally. I'm frankly not sure why integration tests seem to be performing type checking in the first place. Can you offer any guidance here? Maybe this is related to dependency caching in CI? Thanks! Edit: I see now that it's testing against TS 3.8, and that I need to run |
It looks like the type errors are occurring because Support for this was only introduced in TypeScript 4.1: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-1.html This was introduced to those types 4 years ago: DefinitelyTyped/DefinitelyTyped#51262 And as of 2 years ago, TypeScript <=4.0 is no longer supported by DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#62240 Why is Sentry testing against TypeScript 3.8? This version hasn't been supported for a long time, and |
In 30b8213 I updated the TypeScript 3.8 script to use |
Marking myself as a reviewer, will take a look ASAP!
Because we want to be as a compatible with many users as possible. We said we would support |
I'm not sure why things are failing after getting up to date with |
Looks like the failing tests were fixed in #15001. |
If y'all want to check for a maximally-deduped lockfile in CI (I'd strongly advise this), you can add a Once you're using Yarn v4, this is built in via |
Backport of #14971 to v8. This is a prerequisite for an eventual backport of #14968, which will itself will make applying/backporting #14967 much easier. I ran `yarn build` and `yarn test` locally. Building succeeded, and all but 2 test suites passed. The two that failed also failed for me on `v8` (without any of my changes), so I'm assuming it's something to do with my environment.
I'm splitting this out of #14967 since it was getting a little out of hand in that other PR.
Tests are currently failing, seemingly related to ampproject/remapping#193. It seems like this may only have been fixed in vitest v2? So that might be a blocker for these changes.
There's another strange failure in the
packages/browser
test:However, this also fails for me on the
develop
branch, so this may not be related to these changes.