feat(deps): Upgrade all OpenTelemetry dependencies #14967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwalters512
commented
Jan 9, 2025
| "fflate": "0.8.2", | ||
| "html-webpack-plugin": "^5.5.0", |
There was a problem hiding this comment.
This was reordered by Yarn v4.
| @@ -6,7 +6,6 @@ | |||
| "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/typescript", | |||
| "author": "Sentry", | |||
| "license": "MIT", | |||
| "private": false, | |||
There was a problem hiding this comment.
This was removed by Yarn v4.
|
I'd actually like to land #14968 first. There are two test failures that need to be resolved and it'd be better to do that in a separate PR. |
AbhiPrasad
pushed a commit
that referenced
this pull request
Jan 17, 2025
Backport of #14971 to v8. This is a prerequisite for an eventual backport of #14968, which will itself will make applying/backporting #14967 much easier. I ran `yarn build` and `yarn test` locally. Building succeeded, and all but 2 test suites passed. The two that failed also failed for me on `v8` (without any of my changes), so I'm assuming it's something to do with my environment.
|
assigning myself so I can help push this through - feel free to keep pushing up stuff. |
nwalters512
commented
Jan 20, 2025
AbhiPrasad
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades all
@opentelemetrydependencies to their latest versions.This repo uses Yarn v1 (see #11089), so I couldn't reliably use
yarn upgrade-interactiveto easily upgrade these across the entire project. Instead, I did something a little gross:yarn set version berryyarn upgrade-interactiveyarn.lockyarn installto updateyarn.locknpm yarn-deduplicate yarn.lockto dedupe packages to their latest versions (Yarn v4 has native support foryarn dedupe; Yarn v1 does not)The temporary Yarn v4 upgrade and
yarn-deduplicateaccount for all of the technically unrelated changes in this PR. I don't think they should pose a problem, but I'm happy to revert if desired. Theyarn.lockdeduplication significantly reduces the number of packages that are installed, which should offer a speedup ofyarn installin both local dev and CI.