Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Obsolete WithScope #2677

Merged
merged 7 commits into from
Sep 28, 2023
Merged

feat: Obsolete WithScope #2677

merged 7 commits into from
Sep 28, 2023

Conversation

bitsandfoxes
Copy link
Contributor

Relates to #1585

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Obsolete `WithScope` ([#2677](https://github.com/getsentry/sentry-dotnet/pull/2677))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 0d40018

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

CHANGELOG.md Outdated
@@ -2,6 +2,10 @@

## Unreleased

### Fixes

- `WithScope` has been marked Obsolete ([#2677](https://github.com/getsentry/sentry-dotnet/pull/2677))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be more descriptive on why we're doing this

CHANGELOG.md Outdated Show resolved Hide resolved
@bitsandfoxes bitsandfoxes merged commit 497f56e into main Sep 28, 2023
6 of 7 checks passed
@bitsandfoxes bitsandfoxes deleted the feat/obsolete-withscope branch September 28, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants