-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obsolete unnecessary APIs #1585
Comments
Does scope.Platform qualify? #1590 |
Yes, I think so. |
Another - |
Other good candidates: That's because the SDK avoid calling callbacks if disabled as an optimization. While people put their core business logic inside our callbacks. So the async call can be spared if the sole reason to run it is to fetch data to set to the scope. But WithScope has logic that happens inside and folks expect to always run regardless of Sentry being configured. Local scope works in global mode and local mode and is advised instead. |
We now have separate issues for each of the items mentioned here and we already have the feat/4.0.0 pull request as an umbrella to sit across these (plus all the others)... so closing this issue as redundant. |
This issue will keep track of APIs that we want to remove in the next major release (4.0.0). Will keep this open and update as we find them. See https://github.com/getsentry/sentry-dotnet/blob/main/test/Sentry.Tests/ApiApprovalTests.Run.DotNet6_0.verified.txt for list from the main Sentry project.
WithScope
andWithScopeAsync
#2717The text was updated successfully, but these errors were encountered: